From: Peter Enderborg <peter.enderborg@sony.com>
To: Mark Brown <broonie@kernel.org>, Yingsha Xu <ysxu@hust.edu.cn>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Serge Semin <fancer.lancer@gmail.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: remove return value check of debugfs_create_dir()
Date: Mon, 24 Apr 2023 14:20:45 +0200 [thread overview]
Message-ID: <368e31ae-31b5-839f-72e3-20a27239cb0b@sony.com> (raw)
In-Reply-To: <eb3c6aa6-6820-4e94-8eb0-5abd3b627fcc@sirena.org.uk>
On 4/24/23 13:54, Mark Brown wrote:
> On Sun, Apr 23, 2023 at 02:11:54PM +0800, Yingsha Xu wrote:
>> Smatch complains that:
>> dw_spi_debugfs_init() warn: 'dws->debugfs' is an error pointer
>> or valid
>>
>> Debugfs checks are generally not supposed to be checked for errors
>> and it is not necessary here.
>>
>> Just delete the dead code.
>
> This is very much a question of taste with a range of use cases
> available.
No.
https://lkml.iu.edu/hypermail/linux/kernel/1901.2/05993.html
We can do things with the debug information without filesystem enabled.
next prev parent reply other threads:[~2023-04-24 13:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-23 6:11 Yingsha Xu
2023-04-24 11:54 ` Mark Brown
2023-04-24 12:20 ` Peter Enderborg [this message]
2023-04-24 12:32 ` Mark Brown
2023-04-24 12:53 ` Greg Kroah-Hartman
2023-04-24 13:00 ` Mark Brown
2023-04-24 13:08 ` Greg Kroah-Hartman
2023-04-24 13:17 ` Mark Brown
2023-04-24 13:17 ` Peter Enderborg
2023-04-24 13:22 ` Greg Kroah-Hartman
2023-04-24 13:54 ` Peter Enderborg
2023-04-25 5:31 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=368e31ae-31b5-839f-72e3-20a27239cb0b@sony.com \
--to=peter.enderborg@sony.com \
--cc=broonie@kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ysxu@hust.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®