mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Peter Enderborg <peter.enderborg@sony.com>,
	Yingsha Xu <ysxu@hust.edu.cn>,
	Serge Semin <fancer.lancer@gmail.com>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: remove return value check of debugfs_create_dir()
Date: Mon, 24 Apr 2023 14:00:14 +0100	[thread overview]
Message-ID: <55ab40bb-8b3e-496d-bf45-6c4ebd01e43f@sirena.org.uk> (raw)
In-Reply-To: <2023042421-landowner-magnitude-a38c@gregkh>

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

On Mon, Apr 24, 2023 at 02:53:12PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Apr 24, 2023 at 01:32:14PM +0100, Mark Brown wrote:

> > There's issues with partially created debugfs structures getting in the
> > way of people trying to debug things, just completely ignoring all
> > errors can create confusion as the diagnostic information people believe
> > is being shown to them ends up being partial or mistructured without any
> > indication that this has happened.

> How do you end up with partially created debugfs structures?

The ones I've seen have been name collisions caused by for example the
debugfs structure created being flatter than the device model structure,
though obviously something unanticipated could come up.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2023-04-24 13:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-23  6:11 Yingsha Xu
2023-04-24 11:54 ` Mark Brown
2023-04-24 12:20   ` Peter Enderborg
2023-04-24 12:32     ` Mark Brown
2023-04-24 12:53       ` Greg Kroah-Hartman
2023-04-24 13:00         ` Mark Brown [this message]
2023-04-24 13:08           ` Greg Kroah-Hartman
2023-04-24 13:17             ` Mark Brown
2023-04-24 13:17         ` Peter Enderborg
2023-04-24 13:22           ` Greg Kroah-Hartman
2023-04-24 13:54             ` Peter Enderborg
2023-04-25  5:31               ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55ab40bb-8b3e-496d-bf45-6c4ebd01e43f@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=fancer.lancer@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=peter.enderborg@sony.com \
    --cc=ysxu@hust.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®