* [PATCH v2]tty:serial:mvebu-uart:fix a wrong return
@ 2020-03-05 1:38 tangbin
2020-03-05 6:09 ` Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: tangbin @ 2020-03-05 1:38 UTC (permalink / raw)
To: jslaby; +Cc: gregkh, linux-serial, linux-kernel, tangbin
--v1------------------------------------
in this place,the right return should be
return PTR_ERR(),not return -PTR_ERR()
--v2------------------------------------
in this place, the function should return a
negative value and the PTR_ERR already returns
a negative,so return -PTR_ERR() is wrong.
Signed-off-by: tangbin <tangbin@cmss.chinamobile.com>
---
drivers/tty/serial/mvebu-uart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c
index c12a12556..4e9a59071 100644
--- a/drivers/tty/serial/mvebu-uart.c
+++ b/drivers/tty/serial/mvebu-uart.c
@@ -851,7 +851,7 @@ static int mvebu_uart_probe(struct platform_device *pdev)
port->membase = devm_ioremap_resource(&pdev->dev, reg);
if (IS_ERR(port->membase))
- return -PTR_ERR(port->membase);
+ return PTR_ERR(port->membase);
mvuart = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_uart),
GFP_KERNEL);
--
2.20.1.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2]tty:serial:mvebu-uart:fix a wrong return
2020-03-05 1:38 [PATCH v2]tty:serial:mvebu-uart:fix a wrong return tangbin
@ 2020-03-05 6:09 ` Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2020-03-05 6:09 UTC (permalink / raw)
To: tangbin; +Cc: gregkh, linux-serial, linux-kernel
On 05. 03. 20, 2:38, tangbin wrote:
> in this place, the function should return a
> negative value and the PTR_ERR already returns
> a negative,so return -PTR_ERR() is wrong.
>
> Signed-off-by: tangbin <tangbin@cmss.chinamobile.com>
Acked-by: Jiri Slaby <jslaby@suse.cz>
> ---
> drivers/tty/serial/mvebu-uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c
> index c12a12556..4e9a59071 100644
> --- a/drivers/tty/serial/mvebu-uart.c
> +++ b/drivers/tty/serial/mvebu-uart.c
> @@ -851,7 +851,7 @@ static int mvebu_uart_probe(struct platform_device *pdev)
>
> port->membase = devm_ioremap_resource(&pdev->dev, reg);
> if (IS_ERR(port->membase))
> - return -PTR_ERR(port->membase);
> + return PTR_ERR(port->membase);
>
> mvuart = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_uart),
> GFP_KERNEL);
>
thanks,
--
js
suse labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-05 6:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-05 1:38 [PATCH v2]tty:serial:mvebu-uart:fix a wrong return tangbin
2020-03-05 6:09 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®