From: "Chen, Yu C" <yu.c.chen@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Linux PM list <linux-pm@vger.kernel.org>
Subject: RE: [PATCH] cpufreq: governor: Change confusing struct field and variable names
Date: Thu, 28 Apr 2016 07:07:09 +0000 [thread overview]
Message-ID: <36DF59CE26D8EE47B0655C516E9CE64028748585@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <2024653.a0XKPA0FXA@vostro.rjw.lan>
> -----Original Message-----
> From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net]
> Sent: Thursday, April 28, 2016 7:19 AM
> To: Linux PM list
> Cc: Linux Kernel Mailing List; Viresh Kumar; Chen, Yu C
> Subject: [PATCH] cpufreq: governor: Change confusing struct field and variable
> names
>
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The name of the prev_cpu_wall field in struct cpu_dbs_info is confusing,
> because it doesn't represent wall time, but the previous update time as
> returned by get_cpu_idle_time() (that may be the current value of jiffies_64 in
> some cases, for example).
>
> Moreover, the names of some related variables in dbs_update() take that
> confusion further.
>
> Rename all of those things to make their names reflect the purpose more
> accurately. While at it, drop unnecessary parens from one of the updated
> expressions.
>
> No functional changes.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/cpufreq/cpufreq_governor.c | 22 +++++++++++-----------
> drivers/cpufreq/cpufreq_governor.h | 2 +-
> 2 files changed, 12 insertions(+), 12 deletions(-)
Acked-by: Chen Yu <yu.c.chen@intel.com>
prev parent reply other threads:[~2016-04-28 7:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 23:19 Rafael J. Wysocki
2016-04-28 2:16 ` Viresh Kumar
2016-04-28 7:07 ` Chen, Yu C [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36DF59CE26D8EE47B0655C516E9CE64028748585@shsmsx102.ccr.corp.intel.com \
--to=yu.c.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®