mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: msm8996-oneplus-common: Drop LVS2 voltage constraints
@ 2026-10-29 18:12 Vladlen Grachev via B4 Relay
  2026-10-30  8:49 ` Konrad Dybcio
  0 siblings, 1 reply; 2+ messages in thread
From: Vladlen Grachev via B4 Relay @ 2026-10-29 18:12 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, stable, Vladlen Grachev

From: Vladlen Grachev <webholt@gmail.com>

Since commit 27880745470a ("arm64: dts: qcom: msm8996-oneplus: Add SLPI
VDD_PX"), OnePlus 3T no longer boots: the PM8994 RPM regulator device
fails to probe, so UFS, USB and the display never come up and the phone
hangs on the bootloader splash screen:

  lvs2: failed to get the current voltage: -EINVAL
  qcom_rpm_smd_regulator remoteproc:glink-edge:rpm-requests:regulators:
    lvs2: devm_regulator_register() failed, ret=-22
  qcom_rpm_smd_regulator remoteproc:glink-edge:rpm-requests:regulators:
    probe with driver qcom_rpm_smd_regulator failed with error -22

The switch LVS2 cannot report its voltage, so the regulator core asks
its input supply, vdd_lvs1_2, which is not described on these
boards. Checking the 1.8 V constraint then fails with -EINVAL, and the
RPM regulator driver aborts the probe of all PM8994 regulators.

Drop the constraints, like apq8096-db820c, which describes LVS1/LVS2
without them. Keep the node, so that the SLPI still gets its px-supply.

Describing vdd_lvs1_2-supply as S4, as done on other MSM8996 boards,
would also work, but it would only serve the constraint, which has
nothing to enforce on a switch.

Tested on OnePlus 3T with the msm8996-mainline kernel based on v6.19.5.

Fixes: 27880745470a ("arm64: dts: qcom: msm8996-oneplus: Add SLPI VDD_PX")
Cc: stable@vger.kernel.org
Signed-off-by: Vladlen Grachev <webholt@gmail.com>
---
 arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
index 7a3f8afae..98fc45dc8 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
@@ -497,8 +497,6 @@ vreg_l32a_1p8: l32 {
 		};
 
 		vreg_lvs2a: lvs2 {
-			regulator-min-microvolt = <1800000>;
-			regulator-max-microvolt = <1800000>;
 		};
 	};
 };

---
base-commit: f5672a3dff0291d6a45eb0c258b9d2baeb4dc577
change-id: 20261029-op3t-lvs2-fix-44c8905ce34f

Best regards,
-- 
Vladlen Grachev <webholt@gmail.com>



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: qcom: msm8996-oneplus-common: Drop LVS2 voltage constraints
  2026-10-29 18:12 [PATCH] arm64: dts: qcom: msm8996-oneplus-common: Drop LVS2 voltage constraints Vladlen Grachev via B4 Relay
@ 2026-10-30  8:49 ` Konrad Dybcio
  0 siblings, 0 replies; 2+ messages in thread
From: Konrad Dybcio @ 2026-10-30  8:49 UTC (permalink / raw)
  To: webholt, Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, stable

On 10/29/26 7:12 PM, Vladlen Grachev via B4 Relay wrote:
> From: Vladlen Grachev <webholt@gmail.com>
> 
> Since commit 27880745470a ("arm64: dts: qcom: msm8996-oneplus: Add SLPI
> VDD_PX"), OnePlus 3T no longer boots: the PM8994 RPM regulator device
> fails to probe, so UFS, USB and the display never come up and the phone
> hangs on the bootloader splash screen:
> 
>   lvs2: failed to get the current voltage: -EINVAL
>   qcom_rpm_smd_regulator remoteproc:glink-edge:rpm-requests:regulators:
>     lvs2: devm_regulator_register() failed, ret=-22
>   qcom_rpm_smd_regulator remoteproc:glink-edge:rpm-requests:regulators:
>     probe with driver qcom_rpm_smd_regulator failed with error -22
> 
> The switch LVS2 cannot report its voltage, so the regulator core asks
> its input supply, vdd_lvs1_2, which is not described on these
> boards. Checking the 1.8 V constraint then fails with -EINVAL, and the
> RPM regulator driver aborts the probe of all PM8994 regulators.
> 
> Drop the constraints, like apq8096-db820c, which describes LVS1/LVS2
> without them. Keep the node, so that the SLPI still gets its px-supply.
> 
> Describing vdd_lvs1_2-supply as S4, as done on other MSM8996 boards,
> would also work, but it would only serve the constraint, which has
> nothing to enforce on a switch.
> 
> Tested on OnePlus 3T with the msm8996-mainline kernel based on v6.19.5.
> 
> Fixes: 27880745470a ("arm64: dts: qcom: msm8996-oneplus: Add SLPI VDD_PX")
> Cc: stable@vger.kernel.org
> Signed-off-by: Vladlen Grachev <webholt@gmail.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-10-30  8:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-29 18:12 [PATCH] arm64: dts: qcom: msm8996-oneplus-common: Drop LVS2 voltage constraints Vladlen Grachev via B4 Relay
2026-10-30  8:49 ` Konrad Dybcio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®