[PATCH v1] ata: pata_isapnp: Drop unused assignments from pnp_device_id array

[PATCH v1] ata: pata_isapnp: Drop unused assignments from pnp_device_id array

[Uwe Kleine-König (The Capable Hub)]

Explicitly assigning .driver_data in drivers that don't use this member
is silly and a bit irritating. Drop it. Also simplify the list
terminator entry to be just empty to match what most other device_id
tables do.

There is no changed semantic, not even a change in the compiled result.

Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
 drivers/ata/pata_isapnp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/pata_isapnp.c b/drivers/ata/pata_isapnp.c
index 0f77e0424066..23139009c40e 100644
--- a/drivers/ata/pata_isapnp.c
+++ b/drivers/ata/pata_isapnp.c
@@ -119,8 +119,8 @@ static void isapnp_remove_one(struct pnp_dev *idev)
 
 static struct pnp_device_id isapnp_devices[] = {
   	/* Generic ESDI/IDE/ATA compatible hard disk controller */
-	{.id = "PNP0600", .driver_data = 0},
-	{.id = ""}
+	{ .id = "PNP0600" },
+	{ }
 };
 
 MODULE_DEVICE_TABLE(pnp, isapnp_devices);

base-commit: a87737435cfa134f9cdcc696ba3080759d04cf72
-- 
2.47.3

Re: [PATCH v1] ata: pata_isapnp: Drop unused assignments from pnp_device_id array

[Damien Le Moal]

On 2026/06/10 0:51, Uwe Kleine-König (The Capable Hub) wrote:
> Explicitly assigning .driver_data in drivers that don't use this member
> is silly and a bit irritating. Drop it. Also simplify the list
> terminator entry to be just empty to match what most other device_id
> tables do.
> 
> There is no changed semantic, not even a change in the compiled result.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research

Re: [PATCH v1] ata: pata_isapnp: Drop unused assignments from pnp_device_id array

[Niklas Cassel]

On Tue, 09 Jun 2026 18:51:13 +0200, Uwe Kleine-König (The Capable Hub) wrote:
> Explicitly assigning .driver_data in drivers that don't use this member
> is silly and a bit irritating. Drop it. Also simplify the list
> terminator entry to be just empty to match what most other device_id
> tables do.
> 
> There is no changed semantic, not even a change in the compiled result.
> 
> [...]

Applied to libata/linux.git (for-7.2), thanks!

[1/1] ata: pata_isapnp: Drop unused assignments from pnp_device_id array
      https://git.kernel.org/libata/linux/c/0a77385b

Kind regards,
Niklas