From: Marek Vasut <marex@denx.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
kernel@dh-electronics.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: phy_device: Fix PHY LED blinking code comment
Date: Wed, 26 Jun 2024 21:47:38 +0200 [thread overview]
Message-ID: <36f46cea-0811-47dc-8741-042d9b88df88@denx.de> (raw)
In-Reply-To: <9656eb1a-921b-4f2e-b01f-7df7d890254e@lunn.ch>
On 6/26/24 7:32 PM, Andrew Lunn wrote:
> On Wed, Jun 26, 2024 at 05:06:17AM +0200, Marek Vasut wrote:
>> Fix copy-paste error in the code comment. The code refers to
>> LED blinking configuration, not brightness configuration. It
>> was likely copied from comment above this one which does
>> refer to brightness configuration.
>>
>> Fixes: 4e901018432e ("net: phy: phy_device: Call into the PHY driver to set LED blinking")
>> Signed-off-by: Marek Vasut <marex@denx.de>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> There is a lot of context in this patch. Do you have some odd git diff
> settings?
I did use git format-patch -U10 this time, to make sure that context is
visible. With regular git format-patch, the diff contained only part of
the comment and it wasn't clear from the diff that it does modify
comment above (*led_blink_set)() and not e.g. (*led_brightness_set)() .
prev parent reply other threads:[~2024-06-27 4:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 3:06 Marek Vasut
2024-06-26 17:32 ` Andrew Lunn
2024-06-26 19:47 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36f46cea-0811-47dc-8741-042d9b88df88@denx.de \
--to=marex@denx.de \
--cc=andrew@lunn.ch \
--cc=hkallweit1@gmail.com \
--cc=kernel@dh-electronics.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®