mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Conor.Dooley@microchip.com>
To: <geert+renesas@glider.be>, <broonie@kernel.org>,
	<Daire.McNamara@microchip.com>
Cc: <linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spi: SPI_MICROCHIP_CORE should depend on SOC_MICROCHIP_POLARFIRE
Date: Mon, 11 Jul 2022 10:33:22 +0000	[thread overview]
Message-ID: <373b74b4-657c-b6b7-9532-f6602d6b2a8e@microchip.com> (raw)
In-Reply-To: <4e78693a87d6b83847056d22468c370e7232f390.1657529125.git.geert+renesas@glider.be>

On 11/07/2022 09:45, Geert Uytterhoeven wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The Microchip "hard" FPGA SPI controller is only present on Microchip
> PolarFire SoCs.  Hence add a dependency on SOC_MICROCHIP_POLARFIRE, to
> prevent asking the user about this driver when configuring a kernel
> without Microchip PolarFire SoC support.
> 
> Fixes: 9ac8d17694b66d54 ("spi: add support for microchip fpga spi controllers")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Until I get the "soft" version sorted, makes sense to me.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

> ---
>   drivers/spi/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index e03cd16f4469079e..b1cb7fe129ff86da 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -585,6 +585,7 @@ config SPI_MESON_SPIFC
>   config SPI_MICROCHIP_CORE
>          tristate "Microchip FPGA SPI controllers"
>          depends on SPI_MASTER
> +       depends on SOC_MICROCHIP_POLARFIRE || COMPILE_TEST
>          help
>            This enables the SPI driver for Microchip FPGA SPI controllers.
>            Say Y or M here if you want to use the "hard" controllers on
> --
> 2.25.1
> 


  reply	other threads:[~2022-07-11 11:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-11  8:45 Geert Uytterhoeven
2022-07-11 10:33 ` Conor.Dooley [this message]
2022-07-11 10:46   ` Conor.Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=373b74b4-657c-b6b7-9532-f6602d6b2a8e@microchip.com \
    --to=conor.dooley@microchip.com \
    --cc=Daire.McNamara@microchip.com \
    --cc=broonie@kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®