From: <Conor.Dooley@microchip.com>
To: <geert+renesas@glider.be>, <broonie@kernel.org>,
<Daire.McNamara@microchip.com>
Cc: <linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spi: SPI_MICROCHIP_CORE should depend on SOC_MICROCHIP_POLARFIRE
Date: Mon, 11 Jul 2022 10:46:00 +0000 [thread overview]
Message-ID: <f297d979-4e30-e882-f9da-2e6401123617@microchip.com> (raw)
In-Reply-To: <373b74b4-657c-b6b7-9532-f6602d6b2a8e@microchip.com>
On 11/07/2022 11:33, Conor Dooley wrote:
> On 11/07/2022 09:45, Geert Uytterhoeven wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> The Microchip "hard" FPGA SPI controller is only present on Microchip
>> PolarFire SoCs. Hence add a dependency on SOC_MICROCHIP_POLARFIRE, to
>> prevent asking the user about this driver when configuring a kernel
>> without Microchip PolarFire SoC support.
>>
>> Fixes: 9ac8d17694b66d54 ("spi: add support for microchip fpga spi controllers")
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Until I get the "soft" version sorted, makes sense to me.
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Actually, I was thinking about why the "soft" version would change
anything and I realised that this is not correct.
I rescind my R-b.
You can also use this on the HiFive Unleashed Expansion board via
chiplink:
https://raw.githubusercontent.com/polarfire-soc/polarfire-soc-documentation/master/boards/lc-mpfs-dev-kit/images/updated-lc-libero-design.png
I have never tried this so I forgot about it, but just as the PCI
root port is accessible, so is the SPI.
Sorry!
prev parent reply other threads:[~2022-07-11 11:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 8:45 Geert Uytterhoeven
2022-07-11 10:33 ` Conor.Dooley
2022-07-11 10:46 ` Conor.Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f297d979-4e30-e882-f9da-2e6401123617@microchip.com \
--to=conor.dooley@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®