From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Andrea Righi <arighi@nvidia.com>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched/fair: Restore RCU read lock in set_cpu_sd_state_{busy,idle}()
Date: Fri, 22 May 2026 09:44:15 +0530 [thread overview]
Message-ID: <375744de-2587-477c-ad4a-9eff22a5b4b9@amd.com> (raw)
In-Reply-To: <20260521205115.1689545-1-arighi@nvidia.com>
Hello Andrea,
On 5/22/2026 2:21 AM, Andrea Righi wrote:
> @@ -14070,6 +14070,8 @@ static void nohz_balancer_kick(struct rq *rq)
> static void set_cpu_sd_state_busy(int cpu)
> {
> struct sched_domain *sd;
> +
> + rcu_read_lock();
guard(rcu)() saves on the need for an unlock label but this works fine
too. Feel free to include:
Reviewed-by: K Prateek Nayak <kprateek.nayak@amd.com>
> sd = rcu_dereference_all(per_cpu(sd_llc, cpu));
>
> /*
--
Thanks and Regards,
Prateek
next prev parent reply other threads:[~2026-05-22 4:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 20:51 Andrea Righi
2026-05-22 4:14 ` K Prateek Nayak [this message]
2026-05-22 5:08 ` Andrea Righi
2026-05-22 7:28 ` Peter Zijlstra
2026-05-22 9:10 ` Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=375744de-2587-477c-ad4a-9eff22a5b4b9@amd.com \
--to=kprateek.nayak@amd.com \
--cc=arighi@nvidia.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome