From: Fengguang Wu <fengguang.wu@gmail.com>
To: Cong WANG <xiyou.wangcong@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
Subject: Re: [-mm3 patch]Warning fix: check the return value of kobject_add etc.
Date: Wed, 11 Apr 2007 14:23:49 +0800 [thread overview]
Message-ID: <376272831.09174@ustc.edu.cn> (raw)
Message-ID: <20070411062349.GA5843@mail.ustc.edu.cn> (raw)
In-Reply-To: <2375c9f90703312320m3e895bbap735c2d49da9d5ff9@mail.gmail.com>
On Sun, Apr 01, 2007 at 02:20:46PM +0800, Cong WANG wrote:
> 2007/4/1, Andrew Morton <akpm@linux-foundation.org>:
> >
> >Also, please always prepare patches in `patch -p1' form, as per
> >http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt, thanks.
> >
> >
>
> Sorry. I am confused with this. Does that mean I should make patches
> _upon_ the root kernel source directory or first make a copy of the
> original source code and then diff against the two dirs? But I was
> told that "patches should be based _in_ the root kernel source
> directory" and when only one file was modified just to diff it with
> the original single file. (See Documentation/SubmittingPatches.)
>
> Can you help out? And should I remake this patch? Thanks again!
quilt(http://savannah.nongnu.org/projects/quilt) is your friend.
cd /usr/src/linux
quilt new my-fix.patch
quilt edit mm/readahead.c
quilt refresh --diffstat
quilt diff
...
next prev parent reply other threads:[~2007-04-11 6:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-31 2:30 Cong WANG
2007-04-01 5:31 ` Andrew Morton
2007-04-01 6:20 ` Cong WANG
2007-04-01 6:34 ` Andrew Morton
2007-04-01 6:46 ` Cong WANG
[not found] ` <20070411062349.GA5843@mail.ustc.edu.cn>
2007-04-11 6:23 ` Fengguang Wu [this message]
2007-04-11 6:48 ` WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=376272831.09174@ustc.edu.cn \
--to=fengguang.wu@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®