From: David Howells <dhowells@redhat.com>
To: Andrea Parri <andrea.parri@amarulasolutions.com>
Cc: dhowells@redhat.com, paulmck@linux.vnet.ibm.com,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org,
Andrea Parri <parri.andrea@gmail.com>,
Alan Stern <stern@rowland.harvard.edu>,
Will Deacon <will.deacon@arm.com>,
Boqun Feng <boqun.feng@gmail.com>,
Nicholas Piggin <npiggin@gmail.com>,
Jade Alglave <j.alglave@ucl.ac.uk>,
Luc Maranget <luc.maranget@inria.fr>,
Akira Yokosawa <akiyks@gmail.com>
Subject: Re: [PATCH v2 1/3] locking: Document the semantics of spin_is_locked()
Date: Tue, 03 Apr 2018 16:23:07 +0100 [thread overview]
Message-ID: <3766.1522768987@warthog.procyon.org.uk> (raw)
In-Reply-To: <20180403140715.GA5375@andrea>
Andrea Parri <andrea.parri@amarulasolutions.com> wrote:
> Sorry, but I don't understand your objection: are you suggesting to add
> something like "Always return 0 on !SMP" to the comment? what else?
Something like that, possibly along with a warning that this might not be what
you want. You might actually want it to return true on !SMP, it depends on
what you're using it for.
David
next prev parent reply other threads:[~2018-04-03 15:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-01 16:41 [PATCH v3 0/3] Changes, clean-ups and documentation for spin_is_locked() Andrea Parri
2018-04-01 16:41 ` [PATCH v2 1/3] locking: Document the semantics of spin_is_locked() Andrea Parri
2018-04-02 14:03 ` Alan Stern
2018-04-02 19:35 ` Paul E. McKenney
2018-04-06 19:47 ` [PATCH v4 " Andrea Parri
2018-04-06 21:00 ` Paul E. McKenney
2018-04-06 21:01 ` Randy Dunlap
2018-04-06 21:07 ` Paul E. McKenney
2018-04-06 21:08 ` Randy Dunlap
2018-04-06 21:58 ` Andrea Parri
2018-04-08 21:14 ` Paul E. McKenney
2018-04-08 21:32 ` Randy Dunlap
2018-04-08 22:00 ` Paul E. McKenney
2018-04-01 16:41 ` [PATCH v3 2/3] arm64: Remove smp_mb() from arch_spin_is_locked() Andrea Parri
2018-04-01 16:41 ` [PATCH v3 3/3] locking: Clean up comment and #ifndef for {,queued_}spin_is_locked() Andrea Parri
2018-04-01 18:24 ` [PATCH v3 0/3] Changes, clean-ups and documentation for spin_is_locked() Paul E. McKenney
2018-04-03 12:49 ` [PATCH v2 1/3] locking: Document the semantics of spin_is_locked() David Howells
2018-04-03 13:35 ` Andrea Parri
2018-04-03 13:52 ` David Howells
2018-04-03 14:07 ` Andrea Parri
2018-04-03 14:17 ` Paul E. McKenney
2018-04-03 14:43 ` Peter Zijlstra
2018-04-03 15:03 ` Paul E. McKenney
2018-04-03 16:11 ` Paul E. McKenney
2018-04-03 15:23 ` David Howells [this message]
2018-04-03 19:31 ` Andrea Parri
2018-04-03 20:04 ` Alan Stern
2018-04-03 21:43 ` David Howells
2018-04-03 21:47 ` Randy Dunlap
2018-04-04 12:47 ` Andrea Parri
2018-04-04 21:22 ` David Howells
2018-04-05 7:47 ` Christoph Hellwig
2018-04-05 8:56 ` Andrea Parri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3766.1522768987@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=akiyks@gmail.com \
--cc=andrea.parri@amarulasolutions.com \
--cc=boqun.feng@gmail.com \
--cc=j.alglave@ucl.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.maranget@inria.fr \
--cc=mingo@redhat.com \
--cc=npiggin@gmail.com \
--cc=parri.andrea@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome