mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kumar Gala <kumar.gala@freescale.com>
To: Andrew Morton <akpm@osdl.org>
Cc: "Gala Kumar K.-galak" <galak@freescale.com>,
	<linux-kernel@vger.kernel.org>, <linuxppc-embedded@ozlabs.org>,
	"McClintock Matthew-R56630" <msm@freescale.com>
Subject: Re: [PATCH] ppc32: Added support for the Book-E style Watchdog Timer
Date: Tue, 9 Aug 2005 17:42:31 -0500	[thread overview]
Message-ID: <3779A304-7AFC-4476-B0FC-794BD0351270@freescale.com> (raw)
In-Reply-To: <20050809150131.7eac43ad.akpm@osdl.org>


On Aug 9, 2005, at 5:01 PM, Andrew Morton wrote:

> Kumar Gala <galak@freescale.com> wrote:
>
>>
>> PowerPC 40x and Book-E processors support a watchdog timer at the
>>
> processor
>
>> core level.  The timer has implementation dependent timeout
>>
> frequencies
>
>> that can be configured by software.
>>
>> One the first Watchdog timeout we get a critical exception.  It is
>>
> left
>
>> to board specific code to determine what should happen at this point.
>>
> If
>
>> nothing is done and another timeout period expires the processor may
>> attempt to reset the machine.
>>
>> Command line parameters:
>>   wdt=0 : disable watchdog (default)
>>   wdt=1 : enable watchdog
>>
>>   wdt_period=N : N sets the value of the Watchdog Timer Period.
>>
>>   The Watchdog Timer Period meaning is implementation specific. Check
>>   User Manual for the processor for more details.
>>
>> This patch is based off of work done by Takeharu Kato.
>>
>> ...
>>
>> +#ifdef CONFIG_BOOKE_WDT
>> +/* Checks wdt=x and wdt_period=xx command-line option */
>> +int __init early_parse_wdt(char *p)
>> +{
>> +    extern u32 wdt_enable;
>> +
>> +    if (p && strncmp(p, "0", 1) != 0)
>> +           wdt_enable = 1;
>> +
>> +    return 0;
>> +}
>> +early_param("wdt", early_parse_wdt);
>> +
>> +int __init early_parse_wdt_period (char *p)
>> +{
>> +    extern u32 wdt_period;
>> +
>> +    if (p)
>> +        wdt_period = simple_strtoul(p, NULL, 0);
>> +
>> +    return 0;
>> +}
>>
>
>
> Would prefer to see the declaration of wdt_period in a header file,
> please.
>
> But beware that wdt_enable() is already a static symbol in a couple of
> watchdog drivers.  It might be best to rename the ppc global to
> something
> less generic-sounding while you're there.

Ok, will make these changes and send an updated patch.

- kumar


      reply	other threads:[~2005-08-09 22:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-09 20:31 Kumar Gala
2005-08-09 22:01 ` Andrew Morton
2005-08-09 22:42   ` Kumar Gala [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3779A304-7AFC-4476-B0FC-794BD0351270@freescale.com \
    --to=kumar.gala@freescale.com \
    --cc=akpm@osdl.org \
    --cc=galak@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-embedded@ozlabs.org \
    --cc=msm@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®