From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Swapnil Jakhade <sjakhade@cadence.com>, <airlied@linux.ie>,
<daniel@ffwll.ch>, <Laurent.pinchart@ideasonboard.com>,
<robh+dt@kernel.org>, <a.hajda@samsung.com>,
<narmstrong@baylibre.com>, <jonas@kwiboo.se>,
<jernej.skrabec@siol.net>, <dri-devel@lists.freedesktop.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <mparab@cadence.com>, <yamonkar@cadence.com>, <jsarha@ti.com>,
<nsekhar@ti.com>, <praneeth@ti.com>, <nikhil.nd@ti.com>
Subject: Re: [PATCH v10 1/3] dt-bindings: drm/bridge: Document Cadence MHDP8546 bridge bindings
Date: Wed, 16 Sep 2020 15:17:54 +0300 [thread overview]
Message-ID: <37aacded-72e3-eaa9-f97e-488733da98ba@ti.com> (raw)
In-Reply-To: <1600087715-15729-2-git-send-email-sjakhade@cadence.com>
WARNING: multiple messages have this Message-ID
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Swapnil Jakhade <sjakhade@cadence.com>, <airlied@linux.ie>,
<daniel@ffwll.ch>, <Laurent.pinchart@ideasonboard.com>,
<robh+dt@kernel.org>, <a.hajda@samsung.com>,
<narmstrong@baylibre.com>, <jonas@kwiboo.se>,
<jernej.skrabec@siol.net>, <dri-devel@lists.freedesktop.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <mparab@cadence.com>, <yamonkar@cadence.com>, <jsarha@ti.com>,
<nsekhar@ti.com>, <praneeth@ti.com>, <nikhil.nd@ti.com>
Subject: Re: [PATCH v10 1/3] dt-bindings: drm/bridge: Document Cadence MHDP8546 bridge bindings
Date: Wed, 16 Sep 2020 15:17:54 +0300 [thread overview]
Message-ID: <37aacded-72e3-eaa9-f97e-488733da98ba@ti.com> (raw)
Message-ID: <20200916121754.crEGPsCFJ-tWMZ_SPE9hz500nS2gVzC72RjO1WFYrjA@z> (raw)
In-Reply-To: <1600087715-15729-2-git-send-email-sjakhade@cadence.com>
Hi Swapnil, Yuti,
On 14/09/2020 15:48, Swapnil Jakhade wrote:
> From: Yuti Amonkar <yamonkar@cadence.com>
>
> Document the bindings used for the Cadence MHDP8546 DPI/DP bridge in
> yaml format.
>
> Signed-off-by: Yuti Amonkar <yamonkar@cadence.com>
> Signed-off-by: Swapnil Jakhade <sjakhade@cadence.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> .../display/bridge/cdns,mhdp8546.yaml | 154 ++++++++++++++++++
> 1 file changed, 154 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
I was testing this on J7 EVM, and looking at the dts files and DT bindings. To
get rid of the warnings from dtbs_check, I made the following changes.
I think the interrupt one is clear. The driver needs the interrupt, but it was
not defined in the yaml file.
For phy-names, we had that in the out-of-tree dts file, so I added it here. The
driver just looks for the PHY via index, but I guess we should require it.
The power-domain is not needed by the driver, but if I'm not mistaken, has to
be defined here.
diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
index a21a4bfe15cf..c5f5781c1ed6 100644
--- a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
@@ -46,6 +46,16 @@ properties:
description:
phandle to the DisplayPort PHY.
+ phy-names:
+ items:
+ - const: dpphy
+
+ power-domains:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
ports:
type: object
description:
@@ -114,6 +124,8 @@ required:
- reg
- reg-names
- phys
+ - phy-names
+ - interrupts
- ports
additionalProperties: false
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-09-16 18:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 12:48 [PATCH v10 0/3] drm: Add support for Cadence MHDP8546 DPI/DP bridge and J721E wrapper Swapnil Jakhade
2020-09-14 12:48 ` [PATCH v10 1/3] dt-bindings: drm/bridge: Document Cadence MHDP8546 bridge bindings Swapnil Jakhade
2020-09-16 12:17 ` Tomi Valkeinen [this message]
2020-09-16 12:17 ` Tomi Valkeinen
2020-09-18 7:27 ` Swapnil Kashinath Jakhade
2020-09-14 12:48 ` [PATCH v10 2/3] drm: bridge: Add support for Cadence MHDP8546 DPI/DP bridge Swapnil Jakhade
2020-09-14 12:48 ` [PATCH v10 3/3] drm: bridge: cdns-mhdp8546: Add TI J721E wrapper Swapnil Jakhade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37aacded-72e3-eaa9-f97e-488733da98ba@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=jsarha@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mparab@cadence.com \
--cc=narmstrong@baylibre.com \
--cc=nikhil.nd@ti.com \
--cc=nsekhar@ti.com \
--cc=praneeth@ti.com \
--cc=robh+dt@kernel.org \
--cc=sjakhade@cadence.com \
--cc=yamonkar@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®