* [PATCH] platform/x86/pcengines-apuv2: use KEY_RESTART for front button
@ 2019-07-22 11:36 Enrico Weigelt, metux IT consult
2019-07-25 17:17 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-07-22 11:36 UTC (permalink / raw)
To: linux-kernel; +Cc: info, dvhart, andy, platform-driver-x86
From: Enrico Weigelt <info@metux.net>
The keycode KEY_RESTART is more appropriate for the front button,
as most people use it for things like restart or factory reset.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/platform/x86/pcengines-apuv2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
index b0d3110..4138007c 100644
--- a/drivers/platform/x86/pcengines-apuv2.c
+++ b/drivers/platform/x86/pcengines-apuv2.c
@@ -93,7 +93,7 @@
static struct gpio_keys_button apu2_keys_buttons[] = {
{
- .code = KEY_SETUP,
+ .code = KEY_RESTART,
.active_low = 1,
.desc = "front button",
.type = EV_KEY,
--
1.9.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] platform/x86/pcengines-apuv2: use KEY_RESTART for front button
2019-07-22 11:36 [PATCH] platform/x86/pcengines-apuv2: use KEY_RESTART for front button Enrico Weigelt, metux IT consult
@ 2019-07-25 17:17 ` Andy Shevchenko
2019-07-25 18:50 ` Enrico Weigelt, metux IT consult
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2019-07-25 17:17 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult
Cc: Linux Kernel Mailing List, Darren Hart, Andy Shevchenko, Platform Driver
On Mon, Jul 22, 2019 at 2:36 PM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
>
> From: Enrico Weigelt <info@metux.net>
>
> The keycode KEY_RESTART is more appropriate for the front button,
> as most people use it for things like restart or factory reset.
>
Should it go as Fixes?
> Signed-off-by: Enrico Weigelt <info@metux.net>
> ---
> drivers/platform/x86/pcengines-apuv2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
> index b0d3110..4138007c 100644
> --- a/drivers/platform/x86/pcengines-apuv2.c
> +++ b/drivers/platform/x86/pcengines-apuv2.c
> @@ -93,7 +93,7 @@
>
> static struct gpio_keys_button apu2_keys_buttons[] = {
> {
> - .code = KEY_SETUP,
> + .code = KEY_RESTART,
> .active_low = 1,
> .desc = "front button",
> .type = EV_KEY,
> --
> 1.9.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] platform/x86/pcengines-apuv2: use KEY_RESTART for front button
2019-07-25 17:17 ` Andy Shevchenko
@ 2019-07-25 18:50 ` Enrico Weigelt, metux IT consult
2019-07-25 18:57 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-07-25 18:50 UTC (permalink / raw)
To: Andy Shevchenko, Enrico Weigelt, metux IT consult
Cc: Linux Kernel Mailing List, Darren Hart, Andy Shevchenko, Platform Driver
On 25.07.19 19:17, Andy Shevchenko wrote:
> On Mon, Jul 22, 2019 at 2:36 PM Enrico Weigelt, metux IT consult
> <info@metux.net> wrote:
>>
>> From: Enrico Weigelt <info@metux.net>
>>
>> The keycode KEY_RESTART is more appropriate for the front button,
>> as most people use it for things like restart or factory reset.
>>
>
> Should it go as Fixes?
I think so. Technically, the feature already worked, but the keycode
wasn't semantically fine.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] platform/x86/pcengines-apuv2: use KEY_RESTART for front button
2019-07-25 18:50 ` Enrico Weigelt, metux IT consult
@ 2019-07-25 18:57 ` Andy Shevchenko
2019-07-25 19:06 ` Enrico Weigelt, metux IT consult
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2019-07-25 18:57 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult
Cc: Enrico Weigelt, metux IT consult, Linux Kernel Mailing List,
Darren Hart, Andy Shevchenko, Platform Driver
On Thu, Jul 25, 2019 at 9:50 PM Enrico Weigelt, metux IT consult
<lkml@metux.net> wrote:
>
> On 25.07.19 19:17, Andy Shevchenko wrote:
> > On Mon, Jul 22, 2019 at 2:36 PM Enrico Weigelt, metux IT consult
> > <info@metux.net> wrote:
> >>
> >> From: Enrico Weigelt <info@metux.net>
> >>
> >> The keycode KEY_RESTART is more appropriate for the front button,
> >> as most people use it for things like restart or factory reset.
> >>
> >
> > Should it go as Fixes?
>
> I think so. Technically, the feature already worked, but the keycode
> wasn't semantically fine.
Can you provide a Fixes tag?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] platform/x86/pcengines-apuv2: use KEY_RESTART for front button
2019-07-25 18:57 ` Andy Shevchenko
@ 2019-07-25 19:06 ` Enrico Weigelt, metux IT consult
0 siblings, 0 replies; 5+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-07-25 19:06 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Enrico Weigelt, metux IT consult, Linux Kernel Mailing List,
Darren Hart, Andy Shevchenko, Platform Driver
On 25.07.19 20:57, Andy Shevchenko wrote:
> On Thu, Jul 25, 2019 at 9:50 PM Enrico Weigelt, metux IT consult
> <lkml@metux.net> wrote:
>>
>> On 25.07.19 19:17, Andy Shevchenko wrote:
>>> On Mon, Jul 22, 2019 at 2:36 PM Enrico Weigelt, metux IT consult
>>> <info@metux.net> wrote:
>>>>
>>>> From: Enrico Weigelt <info@metux.net>
>>>>
>>>> The keycode KEY_RESTART is more appropriate for the front button,
>>>> as most people use it for things like restart or factory reset.
>>>>
>>>
>>> Should it go as Fixes?
>>
>> I think so. Technically, the feature already worked, but the keycode
>> wasn't semantically fine.
>
> Can you provide a Fixes tag?
>
Okay, sent a v2.
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-25 19:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-22 11:36 [PATCH] platform/x86/pcengines-apuv2: use KEY_RESTART for front button Enrico Weigelt, metux IT consult
2019-07-25 17:17 ` Andy Shevchenko
2019-07-25 18:50 ` Enrico Weigelt, metux IT consult
2019-07-25 18:57 ` Andy Shevchenko
2019-07-25 19:06 ` Enrico Weigelt, metux IT consult
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®