* [PATCH] dt-bindings: ata: ahci-ceva: Cover all 4 iommus entries
@ 2023-05-02 13:48 Michal Simek
2023-05-02 20:15 ` Krzysztof Kozlowski
2023-05-04 2:34 ` Damien Le Moal
0 siblings, 2 replies; 4+ messages in thread
From: Michal Simek @ 2023-05-02 13:48 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git
Cc: Damien Le Moal, Krzysztof Kozlowski, Piyush Mehta, Rob Herring,
devicetree, linux-ide
Current only one entry is enabled but IP itself is using 4 different IDs
which are already listed in zynqmp.dtsi.
sata: ahci@fd0c0000 {
compatible = "ceva,ahci-1v84";
...
iommus = <&smmu 0x4c0>, <&smmu 0x4c1>,
<&smmu 0x4c2>, <&smmu 0x4c3>;
};
Signed-off-by: Michal Simek <michal.simek@amd.com>
---
Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml b/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml
index 9b31f864e071..71364c6081ff 100644
--- a/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml
+++ b/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml
@@ -32,7 +32,7 @@ properties:
maxItems: 1
iommus:
- maxItems: 1
+ maxItems: 4
power-domains:
maxItems: 1
--
2.36.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: ata: ahci-ceva: Cover all 4 iommus entries
2023-05-02 13:48 [PATCH] dt-bindings: ata: ahci-ceva: Cover all 4 iommus entries Michal Simek
@ 2023-05-02 20:15 ` Krzysztof Kozlowski
2023-05-04 2:34 ` Damien Le Moal
1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-02 20:15 UTC (permalink / raw)
To: Michal Simek, linux-kernel, monstr, michal.simek, git
Cc: Damien Le Moal, Krzysztof Kozlowski, Piyush Mehta, Rob Herring,
devicetree, linux-ide
On 02/05/2023 15:48, Michal Simek wrote:
> Current only one entry is enabled but IP itself is using 4 different IDs
> which are already listed in zynqmp.dtsi.
>
> sata: ahci@fd0c0000 {
> compatible = "ceva,ahci-1v84";
> ...
> iommus = <&smmu 0x4c0>, <&smmu 0x4c1>,
> <&smmu 0x4c2>, <&smmu 0x4c3>;
> };
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: ata: ahci-ceva: Cover all 4 iommus entries
2023-05-02 13:48 [PATCH] dt-bindings: ata: ahci-ceva: Cover all 4 iommus entries Michal Simek
2023-05-02 20:15 ` Krzysztof Kozlowski
@ 2023-05-04 2:34 ` Damien Le Moal
2023-05-05 11:17 ` Michal Simek
1 sibling, 1 reply; 4+ messages in thread
From: Damien Le Moal @ 2023-05-04 2:34 UTC (permalink / raw)
To: Michal Simek, linux-kernel, monstr, michal.simek, git
Cc: Krzysztof Kozlowski, Piyush Mehta, Rob Herring, devicetree, linux-ide
On 5/2/23 22:48, Michal Simek wrote:
> Current only one entry is enabled but IP itself is using 4 different IDs
> which are already listed in zynqmp.dtsi.
>
> sata: ahci@fd0c0000 {
> compatible = "ceva,ahci-1v84";
> ...
> iommus = <&smmu 0x4c0>, <&smmu 0x4c1>,
> <&smmu 0x4c2>, <&smmu 0x4c3>;
> };
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml b/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml
> index 9b31f864e071..71364c6081ff 100644
> --- a/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml
> +++ b/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml
> @@ -32,7 +32,7 @@ properties:
> maxItems: 1
>
> iommus:
> - maxItems: 1
> + maxItems: 4
>
> power-domains:
> maxItems: 1
Is this a bug fix ? If yes, what about adding Fixes & Cc: stable tags ?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: ata: ahci-ceva: Cover all 4 iommus entries
2023-05-04 2:34 ` Damien Le Moal
@ 2023-05-05 11:17 ` Michal Simek
0 siblings, 0 replies; 4+ messages in thread
From: Michal Simek @ 2023-05-05 11:17 UTC (permalink / raw)
To: Damien Le Moal, linux-kernel, monstr, michal.simek, git
Cc: Krzysztof Kozlowski, Piyush Mehta, Rob Herring, devicetree, linux-ide
On 5/4/23 04:34, Damien Le Moal wrote:
> On 5/2/23 22:48, Michal Simek wrote:
>> Current only one entry is enabled but IP itself is using 4 different IDs
>> which are already listed in zynqmp.dtsi.
>>
>> sata: ahci@fd0c0000 {
>> compatible = "ceva,ahci-1v84";
>> ...
>> iommus = <&smmu 0x4c0>, <&smmu 0x4c1>,
>> <&smmu 0x4c2>, <&smmu 0x4c3>;
>> };
>>
>> Signed-off-by: Michal Simek <michal.simek@amd.com>
>> ---
>>
>> Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml b/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml
>> index 9b31f864e071..71364c6081ff 100644
>> --- a/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml
>> +++ b/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml
>> @@ -32,7 +32,7 @@ properties:
>> maxItems: 1
>>
>> iommus:
>> - maxItems: 1
>> + maxItems: 4
>>
>> power-domains:
>> maxItems: 1
>
> Is this a bug fix ? If yes, what about adding Fixes & Cc: stable tags ?
I can do that no issue.
Thanks,
Michal
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-05 11:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-02 13:48 [PATCH] dt-bindings: ata: ahci-ceva: Cover all 4 iommus entries Michal Simek
2023-05-02 20:15 ` Krzysztof Kozlowski
2023-05-04 2:34 ` Damien Le Moal
2023-05-05 11:17 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®