* [PATCH net-next] netdev: Remove unused funtions
@ 2020-09-16 14:18 YueHaibing
2020-09-16 20:32 ` Saeed Mahameed
2020-09-17 2:19 ` [PATCH v2 net-next] netdev: Remove unused functions YueHaibing
0 siblings, 2 replies; 4+ messages in thread
From: YueHaibing @ 2020-09-16 14:18 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, YueHaibing
There is no callers in tree, so can remove it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
include/linux/netdevice.h | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 157e0242e9ee..909b1fbb0481 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -4677,16 +4677,6 @@ int netdev_class_create_file_ns(const struct class_attribute *class_attr,
void netdev_class_remove_file_ns(const struct class_attribute *class_attr,
const void *ns);
-static inline int netdev_class_create_file(const struct class_attribute *class_attr)
-{
- return netdev_class_create_file_ns(class_attr, NULL);
-}
-
-static inline void netdev_class_remove_file(const struct class_attribute *class_attr)
-{
- netdev_class_remove_file_ns(class_attr, NULL);
-}
-
extern const struct kobj_ns_type_operations net_ns_type_operations;
const char *netdev_drivername(const struct net_device *dev);
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] netdev: Remove unused funtions
2020-09-16 14:18 [PATCH net-next] netdev: Remove unused funtions YueHaibing
@ 2020-09-16 20:32 ` Saeed Mahameed
2020-09-17 2:19 ` [PATCH v2 net-next] netdev: Remove unused functions YueHaibing
1 sibling, 0 replies; 4+ messages in thread
From: Saeed Mahameed @ 2020-09-16 20:32 UTC (permalink / raw)
To: YueHaibing, davem, kuba; +Cc: netdev, linux-kernel
On Wed, 2020-09-16 at 22:18 +0800, YueHaibing wrote:
> There is no callers in tree, so can remove it.
>
You have a typo in the patch title:
funtions -> functions
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Please feel free to add my R.B tag after on V2.
Reviewed-by: Saeed Mahameed <saeedm@nvidia.com>
And by the way, you have 3 patches doing similar things, please
consider submitting them as one series on V2:
$ git format-patch --cover-letter \
--subject-prefix="PATCH net-next" HEAD~3.. -o patches/
> ---
> include/linux/netdevice.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 157e0242e9ee..909b1fbb0481 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -4677,16 +4677,6 @@ int netdev_class_create_file_ns(const struct
> class_attribute *class_attr,
> void netdev_class_remove_file_ns(const struct class_attribute
> *class_attr,
> const void *ns);
>
> -static inline int netdev_class_create_file(const struct
> class_attribute *class_attr)
> -{
> - return netdev_class_create_file_ns(class_attr, NULL);
> -}
> -
> -static inline void netdev_class_remove_file(const struct
> class_attribute *class_attr)
> -{
> - netdev_class_remove_file_ns(class_attr, NULL);
> -}
> -
> extern const struct kobj_ns_type_operations net_ns_type_operations;
>
> const char *netdev_drivername(const struct net_device *dev);
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2 net-next] netdev: Remove unused functions
2020-09-16 14:18 [PATCH net-next] netdev: Remove unused funtions YueHaibing
2020-09-16 20:32 ` Saeed Mahameed
@ 2020-09-17 2:19 ` YueHaibing
2020-09-17 23:52 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: YueHaibing @ 2020-09-17 2:19 UTC (permalink / raw)
To: davem, kuba, saeed; +Cc: netdev, linux-kernel, YueHaibing
There is no callers in tree, so can remove it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Saeed Mahameed <saeedm@nvidia.com>
---
v2: fix title typo 'funtions' --> 'functions'
---
include/linux/netdevice.h | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 157e0242e9ee..909b1fbb0481 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -4677,16 +4677,6 @@ int netdev_class_create_file_ns(const struct class_attribute *class_attr,
void netdev_class_remove_file_ns(const struct class_attribute *class_attr,
const void *ns);
-static inline int netdev_class_create_file(const struct class_attribute *class_attr)
-{
- return netdev_class_create_file_ns(class_attr, NULL);
-}
-
-static inline void netdev_class_remove_file(const struct class_attribute *class_attr)
-{
- netdev_class_remove_file_ns(class_attr, NULL);
-}
-
extern const struct kobj_ns_type_operations net_ns_type_operations;
const char *netdev_drivername(const struct net_device *dev);
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-17 23:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16 14:18 [PATCH net-next] netdev: Remove unused funtions YueHaibing
2020-09-16 20:32 ` Saeed Mahameed
2020-09-17 2:19 ` [PATCH v2 net-next] netdev: Remove unused functions YueHaibing
2020-09-17 23:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®