mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 1/1] regulator: pca9450: Fix BUCK2 enable_mask
@ 2023-05-10 13:57 Alexander Stein
  2023-05-10 14:13 ` Frieder Schrempf
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Alexander Stein @ 2023-05-10 13:57 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, Frieder Schrempf, Robin Gong
  Cc: Alexander Stein, linux-kernel

This fixes a copy & paste error.
No functional change intended, BUCK1_ENMODE_MASK equals BUCK2_ENMODE_MASK.

Fixes: 0935ff5f1f0a ("regulator: pca9450: add pca9450 pmic driver")
Originally-from: Robin Gong <yibin.gong@nxp.com>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Changes in v2:
* Explicitly mention in the commit message that there is no functional
  change

This diff is extracted from a downstream commit authored by Robin Gong.

 drivers/regulator/pca9450-regulator.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c
index 9d0ed87f7e32..4983163130c6 100644
--- a/drivers/regulator/pca9450-regulator.c
+++ b/drivers/regulator/pca9450-regulator.c
@@ -265,7 +265,7 @@ static const struct pca9450_regulator_desc pca9450a_regulators[] = {
 			.vsel_reg = PCA9450_REG_BUCK2OUT_DVS0,
 			.vsel_mask = BUCK2OUT_DVS0_MASK,
 			.enable_reg = PCA9450_REG_BUCK2CTRL,
-			.enable_mask = BUCK1_ENMODE_MASK,
+			.enable_mask = BUCK2_ENMODE_MASK,
 			.enable_val = BUCK_ENMODE_ONREQ_STBYREQ,
 			.ramp_reg = PCA9450_REG_BUCK2CTRL,
 			.ramp_mask = BUCK2_RAMP_MASK,
@@ -509,7 +509,7 @@ static const struct pca9450_regulator_desc pca9450bc_regulators[] = {
 			.vsel_reg = PCA9450_REG_BUCK2OUT_DVS0,
 			.vsel_mask = BUCK2OUT_DVS0_MASK,
 			.enable_reg = PCA9450_REG_BUCK2CTRL,
-			.enable_mask = BUCK1_ENMODE_MASK,
+			.enable_mask = BUCK2_ENMODE_MASK,
 			.enable_val = BUCK_ENMODE_ONREQ_STBYREQ,
 			.ramp_reg = PCA9450_REG_BUCK2CTRL,
 			.ramp_mask = BUCK2_RAMP_MASK,
-- 
2.34.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/1] regulator: pca9450: Fix BUCK2 enable_mask
  2023-05-10 13:57 [PATCH v2 1/1] regulator: pca9450: Fix BUCK2 enable_mask Alexander Stein
@ 2023-05-10 14:13 ` Frieder Schrempf
  2023-05-11  1:27 ` Mark Brown
  2023-05-15 10:56 ` Mark Brown
  2 siblings, 0 replies; 4+ messages in thread
From: Frieder Schrempf @ 2023-05-10 14:13 UTC (permalink / raw)
  To: Alexander Stein, Liam Girdwood, Mark Brown, Robin Gong; +Cc: linux-kernel

On 10.05.23 15:57, Alexander Stein wrote:
> This fixes a copy & paste error.
> No functional change intended, BUCK1_ENMODE_MASK equals BUCK2_ENMODE_MASK.
> 
> Fixes: 0935ff5f1f0a ("regulator: pca9450: add pca9450 pmic driver")
> Originally-from: Robin Gong <yibin.gong@nxp.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/1] regulator: pca9450: Fix BUCK2 enable_mask
  2023-05-10 13:57 [PATCH v2 1/1] regulator: pca9450: Fix BUCK2 enable_mask Alexander Stein
  2023-05-10 14:13 ` Frieder Schrempf
@ 2023-05-11  1:27 ` Mark Brown
  2023-05-15 10:56 ` Mark Brown
  2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2023-05-11  1:27 UTC (permalink / raw)
  To: Alexander Stein; +Cc: Liam Girdwood, Frieder Schrempf, Robin Gong, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

On Wed, May 10, 2023 at 03:57:18PM +0200, Alexander Stein wrote:
> This fixes a copy & paste error.
> No functional change intended, BUCK1_ENMODE_MASK equals BUCK2_ENMODE_MASK.

This doesn't apply against current code, please check and resend.  git
can't find the SHAs this is based on...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/1] regulator: pca9450: Fix BUCK2 enable_mask
  2023-05-10 13:57 [PATCH v2 1/1] regulator: pca9450: Fix BUCK2 enable_mask Alexander Stein
  2023-05-10 14:13 ` Frieder Schrempf
  2023-05-11  1:27 ` Mark Brown
@ 2023-05-15 10:56 ` Mark Brown
  2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2023-05-15 10:56 UTC (permalink / raw)
  To: Liam Girdwood, Frieder Schrempf, Robin Gong, Alexander Stein; +Cc: linux-kernel

On Wed, 10 May 2023 15:57:18 +0200, Alexander Stein wrote:
> This fixes a copy & paste error.
> No functional change intended, BUCK1_ENMODE_MASK equals BUCK2_ENMODE_MASK.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: pca9450: Fix BUCK2 enable_mask
      commit: d67dada3e2524514b09496b9ee1df22d4507a280

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-05-15 10:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-10 13:57 [PATCH v2 1/1] regulator: pca9450: Fix BUCK2 enable_mask Alexander Stein
2023-05-10 14:13 ` Frieder Schrempf
2023-05-11  1:27 ` Mark Brown
2023-05-15 10:56 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®