From: Sudeep Holla <sudeep.holla@arm.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] coresight: fix handling of ETM trace register access via sysfs
Date: Thu, 4 Aug 2016 16:58:41 +0100 [thread overview]
Message-ID: <37cade42-0cc0-e623-59a7-ecdc9e959ba8@arm.com> (raw)
In-Reply-To: <CANLsYkxRS+2xGNtPBNVaddRXAbXZc+vnbj2VK=7ifD9PoV=0SQ@mail.gmail.com>
On 04/08/16 16:46, Mathieu Poirier wrote:
> On 3 August 2016 at 10:12, Sudeep Holla <sudeep.holla@arm.com> wrote:
>> The ETM registers are classified into 2 categories: trace and management.
>> The core power domain contains most of the trace unit logic including
>> all(except TRCOSLAR and TRCOSLSR) the trace registers. The debug power
>> domain contains the external debugger interface including all management
>> registers.
>>
>> This patch adds coresight unit specific function coresight_simple_func
>> which can be used for ETM trace registers by providing a ETM specific
>> read function which does smp cross call to ensure the trace core is
>> powered up before the register is accessed.
>>
>> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>
> Hey Sudeep,
>
> I'm good with this patch - just a few things to amend below.
>
> Many thanks,
> Mathieu
>
>> ---
>> drivers/hwtracing/coresight/coresight-etb10.c | 2 +-
>> .../hwtracing/coresight/coresight-etm3x-sysfs.c | 2 +-
>> .../hwtracing/coresight/coresight-etm4x-sysfs.c | 58 ++++++++++++++++------
>> drivers/hwtracing/coresight/coresight-etm4x.h | 1 +
>> drivers/hwtracing/coresight/coresight-priv.h | 9 +++-
>> drivers/hwtracing/coresight/coresight-stm.c | 2 +-
>> drivers/hwtracing/coresight/coresight-tmc.c | 2 +-
>> 7 files changed, 54 insertions(+), 22 deletions(-)
>>
>> Hi Mathieu,
>>
>> I think the latest release of the firmware(inparticular SCP v1.16.0) for
>
> Is this public? If so please give me the link so that we test with
> the same environment.
>
Yes I believe so. You should be able to grab latest @[1]
I agree with all the other comments, will repost v2 soon.
--
Regards,
Sudeep
[1]
https://snapshots.linaro.org/member-builds/armlt-platforms-release/28/juno-uefi.zip
next prev parent reply other threads:[~2016-08-04 16:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 16:12 [PATCH 1/2] coresight: etm4x: request to retain power to the trace unit when active Sudeep Holla
2016-08-03 16:12 ` [PATCH 2/2] coresight: fix handling of ETM trace register access via sysfs Sudeep Holla
2016-08-04 15:46 ` Mathieu Poirier
2016-08-04 15:58 ` Sudeep Holla [this message]
2016-08-04 16:02 ` Mathieu Poirier
2016-08-04 16:11 ` Sudeep Holla
2016-08-04 16:22 ` [PATCH v2 " Sudeep Holla
2016-08-04 17:15 ` Mathieu Poirier
2016-08-04 17:15 ` [PATCH 1/2] coresight: etm4x: request to retain power to the trace unit when active Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37cade42-0cc0-e623-59a7-ecdc9e959ba8@arm.com \
--to=sudeep.holla@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®