From: "Shunxi Zhang (章顺喜)" <ot_shunxi.zhang@mediatek.com>
To: "Eddie Huang (黃智傑)" <eddie.huang@mediatek.com>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"Vince-WL Liu (劉文龍)" <Vince-WL.Liu@mediatek.com>,
"krzk@kernel.org" <krzk@kernel.org>,
"Jh Hsu (許希孜)" <Jh.Hsu@mediatek.com>,
"Sean Wang" <Sean.Wang@mediatek.com>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"lee@kernel.org" <lee@kernel.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"Sirius Wang (王皓昱)" <Sirius.Wang@mediatek.com>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 4/5] rtc: mt6397: Add BBPU alarm status reset and shutdown handling
Date: Fri, 21 Nov 2025 03:20:27 +0000 [thread overview]
Message-ID: <37dc95982cc37fbd78b8fee6c11b709d3171bd7a.camel@mediatek.com> (raw)
In-Reply-To: <44783f62-c8da-4c5c-a927-f9ce80df8e37@kernel.org>
On Thu, 2025-11-20 at 14:40 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> On 20/11/2025 13:18, ot_shunxi.zhang@mediatek.com wrote:
> >
> > rtc = devm_kzalloc(&pdev->dev, sizeof(struct mt6397_rtc),
> > GFP_KERNEL);
> > @@ -275,6 +294,8 @@ static int mtk_rtc_probe(struct platform_device
> > *pdev)
> > if (IS_ERR(rtc->rtc_dev))
> > return PTR_ERR(rtc->rtc_dev);
> >
> > + rtc->alarm_sta_supported = of_property_read_bool(np,
> > "mediatek,alarm-sta-supported");
>
> You cannot add undocumented ABI. Read carefully Linux documentation.
>
> Best regards,
> Krzysztof
Dear sir,
Thanks for your comment, I will read & check linux documentation.
It will be revised in the next version.
Best Regards
Shunxi Zhang
next prev parent reply other threads:[~2025-11-21 3:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 12:17 [PATCH v2 0/5] rtc: Enhance RTC driver with BBPU bit definitions " ot_shunxi.zhang
2025-11-20 12:17 ` [PATCH v2 1/5] mfd: mt6397: Fix formatting of RTC_BBPU_KEY definition ot_shunxi.zhang
2025-11-20 13:38 ` Krzysztof Kozlowski
2025-11-21 3:07 ` Shunxi Zhang (章顺喜)
2025-11-21 7:20 ` Krzysztof Kozlowski
2025-11-20 12:17 ` [PATCH v2 2/5] mfd: mt6397: Add bit definitions and struct members to support alarm status ot_shunxi.zhang
2025-11-20 12:17 ` [PATCH v2 3/5] rtc: mt6397: Fix formatting of platform driver structure ot_shunxi.zhang
2025-11-20 13:38 ` Krzysztof Kozlowski
2025-11-21 3:14 ` Shunxi Zhang (章顺喜)
2025-11-20 13:59 ` Alexandre Belloni
2025-11-20 12:18 ` [PATCH v2 4/5] rtc: mt6397: Add BBPU alarm status reset and shutdown handling ot_shunxi.zhang
2025-11-20 13:40 ` Krzysztof Kozlowski
2025-11-21 3:20 ` Shunxi Zhang (章顺喜) [this message]
2025-11-20 14:42 ` AngeloGioacchino Del Regno
2025-11-21 3:43 ` Shunxi Zhang (章顺喜)
2025-11-20 12:18 ` [PATCH v2 5/5] arm64: dts: mediatek: mt6359: Add alarm-sta-supported property to RTC node ot_shunxi.zhang
2025-11-20 13:39 ` Krzysztof Kozlowski
2025-11-21 3:25 ` Shunxi Zhang (章顺喜)
2025-11-20 14:14 ` [PATCH v2 0/5] rtc: Enhance RTC driver with BBPU bit definitions and shutdown handling Rob Herring
2025-11-21 2:45 ` Shunxi Zhang (章顺喜)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37dc95982cc37fbd78b8fee6c11b709d3171bd7a.camel@mediatek.com \
--to=ot_shunxi.zhang@mediatek.com \
--cc=Jh.Hsu@mediatek.com \
--cc=Sean.Wang@mediatek.com \
--cc=Sirius.Wang@mediatek.com \
--cc=Vince-WL.Liu@mediatek.com \
--cc=alexandre.belloni@bootlin.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®