Re: [PATCH v2 5/5] arm64: dts: mediatek: mt6359: Add alarm-sta-supported property to RTC node

["Shunxi Zhang (章顺喜)" <ot_shunxi.zhang@mediatek.com>]

On Thu, 2025-11-20 at 14:39 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 20/11/2025 13:18, ot_shunxi.zhang@mediatek.com wrote:
> > From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> > 
> > This patch adds the 'mediatek,alarm-sta-supported' property to the
> > RTC
> 
> 
> Please do not use "This commit/patch/change", but imperative mood.
> See
> longer explanation here:
> 
https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst*L94__;Iw!!CTRNKA9wMg0ARbw!lG60Q7FoClLZKplNF6BZMm2F_K445Atp1fNnFeABA24zxGbEsB2YpbGS4mjeA99Ir53IUlM3GQTbHQYWg1iJ$
> 
> > node in the MediaTek MT6359 device tree source file. This property
> > indicates that the RTC supports alarm status functionality, which
> > is
> > essential for proper power management and wake-up events.
> > 
> > Signed-off-by: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> > ---
> >  arch/arm64/boot/dts/mediatek/mt6359.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> > index 467d8a4c2aa7..62a2d745c8d2 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> > @@ -302,6 +302,7 @@ mt6359_vsram_others_sshub_ldo:
> > ldo_vsram_others_sshub {
> > 
> >               mt6359rtc: rtc {
> >                       compatible = "mediatek,mt6358-rtc";
> > +                     mediatek,alarm-sta-supported;
> 
> NAK, there is no such ABI.
> 
> Test your code BEFORE you send it.
> 
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> 
https://urldefense.com/v3/__https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/__;!!CTRNKA9wMg0ARbw!lG60Q7FoClLZKplNF6BZMm2F_K445Atp1fNnFeABA24zxGbEsB2YpbGS4mjeA99Ir53IUlM3GQTbHR2UEECz$
> for instructions).
> Maybe you need to update your dtschema and yamllint. Don't rely on
> distro packages for dtschema and be sure you are using the latest
> released dtschema.
> 
> 
> Best regards,
> Krzysztof

Dir sir,
  Thanks for comments; I will check the DTS file again according to the
method you posted. It will be revised in the next version.

Best Regards
Shunxi Zhang