From: Keerthy <j-keerthy@ti.com>
To: Suman Anna <s-anna@ti.com>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"tony@atomide.com" <tony@atomide.com>,
"aaro.koskinen@iki.fi" <aaro.koskinen@iki.fi>
Cc: "Claudiu.Beznea@microchip.com" <Claudiu.Beznea@microchip.com>,
"narmstrong@baylibre.com" <narmstrong@baylibre.com>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"ladis@linux-mips.org" <ladis@linux-mips.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"sebastian.reichel@collabora.co.uk"
<sebastian.reichel@collabora.co.uk>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"Kristo, Tero" <t-kristo@ti.com>,
"Strashko, Grygorii" <grygorii.strashko@ti.com>
Subject: Re: [PATCH v7 3/9] arm: omap: Move dmtimer.h out of plat-omap
Date: Wed, 14 Feb 2018 10:20:33 +0530 [thread overview]
Message-ID: <37f28584-20c2-51c1-e476-75ef81f03af6@ti.com> (raw)
In-Reply-To: <1c9f5c72-f589-d7c7-399f-ef55ecb828a0@ti.com>
On Tuesday 13 February 2018 07:36 AM, Suman Anna wrote:
> Hi Keerthy,
>
> On 01/09/2018 12:23 AM, J, KEERTHY wrote:
>> The header file is currently under plat-omap directory
>> under arch/omap. Move this out to an accessible place.
>>
>> No Code changes done to the header file.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
>> Tested-by: Ladislav Michl <ladis@linux-mips.org>
>> ---
>> arch/arm/mach-omap1/pm.c | 2 +-
>> arch/arm/mach-omap1/timer.c | 2 +-
>> arch/arm/mach-omap2/omap_hwmod_2420_data.c | 2 +-
>> arch/arm/mach-omap2/omap_hwmod_2430_data.c | 2 +-
>> arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c | 2 +-
>> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 2 +-
>> arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 2 +-
>> arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 2 +-
>> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 2 +-
>> arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 2 +-
>> arch/arm/mach-omap2/pdata-quirks.c | 2 +-
>> arch/arm/mach-omap2/timer.c | 2 +-
>> arch/arm/plat-omap/dmtimer.c | 2 +-
>> {arch/arm/plat-omap/include/plat => include/clocksource}/dmtimer.h | 0
>> 14 files changed, 13 insertions(+), 13 deletions(-)
>> rename {arch/arm/plat-omap/include/plat => include/clocksource}/dmtimer.h (100%)
>>
>> diff --git a/arch/arm/mach-omap1/pm.c b/arch/arm/mach-omap1/pm.c
>> index f1135bf..a07d47cf 100644
>> --- a/arch/arm/mach-omap1/pm.c
>> +++ b/arch/arm/mach-omap1/pm.c
>> @@ -55,7 +55,7 @@
>> #include <mach/tc.h>
>> #include <mach/mux.h>
>> #include <linux/omap-dma.h>
>> -#include <plat/dmtimer.h>
>> +#include <clocksource/dmtimer.h>
>>
>> #include <mach/irqs.h>
>>
>> diff --git a/arch/arm/mach-omap1/timer.c b/arch/arm/mach-omap1/timer.c
>> index 8fb1ec6..7c057ab 100644
>> --- a/arch/arm/mach-omap1/timer.c
>> +++ b/arch/arm/mach-omap1/timer.c
>> @@ -27,7 +27,7 @@
>> #include <linux/platform_device.h>
>> #include <linux/platform_data/dmtimer-omap.h>
>>
>> -#include <plat/dmtimer.h>
>> +#include <clocksource/dmtimer.h>
>>
>> #include "soc.h"
>>
>> diff --git a/arch/arm/mach-omap2/omap_hwmod_2420_data.c
>> b/arch/arm/mach-omap2/omap_hwmod_2420_data.c
>> index 0afb014..0a8b95f 100644
>> --- a/arch/arm/mach-omap2/omap_hwmod_2420_data.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod_2420_data.c
>> @@ -16,7 +16,7 @@
>> #include <linux/i2c-omap.h>
>> #include <linux/platform_data/spi-omap2-mcspi.h>
>> #include <linux/omap-dma.h>
>> -#include <plat/dmtimer.h>
>> +#include <clocksource/dmtimer.h>
>>
>> #include "omap_hwmod.h"
>> #include "l3_2xxx.h"
>> diff --git a/arch/arm/mach-omap2/omap_hwmod_2430_data.c
>> b/arch/arm/mach-omap2/omap_hwmod_2430_data.c
>> index 013b26b..16e3d8c 100644
>> --- a/arch/arm/mach-omap2/omap_hwmod_2430_data.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod_2430_data.c
>> @@ -18,7 +18,7 @@
>> #include <linux/platform_data/hsmmc-omap.h>
>> #include <linux/platform_data/spi-omap2-mcspi.h>
>> #include <linux/omap-dma.h>
>> -#include <plat/dmtimer.h>
>> +#include <clocksource/dmtimer.h>
>
> These headers are actually not needed in the first-place since we no
> longer create any non-DT timer devices. I have submitted a series to
> cleanup the presence of this header file, as part of a larger hwmod data
> cleanup series.
I will rebase my series on top of your clean up series. Thanks for clean
ups.
>
>>
>> #include "omap_hwmod.h"
>> #include "l3_2xxx.h"
>> diff --git a/arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c
>> b/arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c
>> index 4b094cb..8a65f70 100644
>> --- a/arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c
>> @@ -11,7 +11,7 @@
>>
>> #include <linux/platform_data/gpio-omap.h>
>> #include <linux/omap-dma.h>
>> -#include <plat/dmtimer.h>
>> +#include <clocksource/dmtimer.h>
>> #include <linux/platform_data/spi-omap2-mcspi.h>
>>
>> #include "omap_hwmod.h"
>> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
>> b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
>> index 1a2f224..b030137 100644
>> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
>> @@ -25,7 +25,7 @@
>> #include "l4_3xxx.h"
>> #include <linux/platform_data/asoc-ti-mcbsp.h>
>> #include <linux/platform_data/spi-omap2-mcspi.h>
>> -#include <plat/dmtimer.h>
>> +#include <clocksource/dmtimer.h>
>>
>> #include "soc.h"
>> #include "omap_hwmod.h"
>> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> index a1901c2..51c7d62 100644
>> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> @@ -30,7 +30,7 @@
>>
>> #include <linux/platform_data/spi-omap2-mcspi.h>
>> #include <linux/platform_data/asoc-ti-mcbsp.h>
>> -#include <plat/dmtimer.h>
>> +#include <clocksource/dmtimer.h>
>>
>> #include "omap_hwmod.h"
>> #include "omap_hwmod_common_data.h"
>> diff --git a/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
>> b/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
>> index 988e7ea..530334e 100644
>> --- a/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
>> @@ -26,7 +26,7 @@
>> #include <linux/omap-dma.h>
>> #include <linux/platform_data/spi-omap2-mcspi.h>
>> #include <linux/platform_data/asoc-ti-mcbsp.h>
>> -#include <plat/dmtimer.h>
>> +#include <clocksource/dmtimer.h>
>>
>> #include "omap_hwmod.h"
>> #include "omap_hwmod_common_data.h"
>> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
>> b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
>> index 4c2a05b..2452649 100644
>> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
>> @@ -26,7 +26,7 @@
>> #include <linux/omap-dma.h>
>> #include <linux/platform_data/spi-omap2-mcspi.h>
>> #include <linux/platform_data/asoc-ti-mcbsp.h>
>> -#include <plat/dmtimer.h>
>> +#include <clocksource/dmtimer.h>
>>
>> #include "omap_hwmod.h"
>> #include "omap_hwmod_common_data.h"
>> diff --git a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
>> b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
>> index 84f1182..94f3bb1 100644
>> --- a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
>> @@ -18,7 +18,7 @@
>> #include <linux/platform_data/gpio-omap.h>
>> #include <linux/platform_data/hsmmc-omap.h>
>> #include <linux/platform_data/spi-omap2-mcspi.h>
>> -#include <plat/dmtimer.h>
>> +#include <clocksource/dmtimer.h>
>>
>> #include "omap_hwmod_common_data.h"
>> #include "cm81xx.h"
>> diff --git a/arch/arm/mach-omap2/pdata-quirks.c b/arch/arm/mach-omap2/pdata-quirks.c
>> index 6b433fc..ad9df86 100644
>> --- a/arch/arm/mach-omap2/pdata-quirks.c
>> +++ b/arch/arm/mach-omap2/pdata-quirks.c
>> @@ -27,7 +27,7 @@
>> #include <linux/platform_data/pwm_omap_dmtimer.h>
>> #include <linux/platform_data/media/ir-rx51.h>
>> #include <linux/platform_data/asoc-ti-mcbsp.h>
>> -#include <plat/dmtimer.h>
>> +#include <clocksource/dmtimer.h>
>>
>> #include "common.h"
>> #include "common-board-devices.h"
>> diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
>> index ece09c9..31c1b01 100644
>> --- a/arch/arm/mach-omap2/timer.c
>> +++ b/arch/arm/mach-omap2/timer.c
>> @@ -26,6 +26,7 @@
>> * License. See the file "COPYING" in the main directory of this archive
>> * for more details.
>> */
>> +#include <clocksource/dmtimer.h>
>> #include <linux/init.h>
>> #include <linux/time.h>
>> #include <linux/interrupt.h>
>> @@ -49,7 +50,6 @@
>> #include "omap_hwmod.h"
>> #include "omap_device.h"
>> #include <plat/counter-32k.h>
>> -#include <plat/dmtimer.h>
>> #include "omap-pm.h"
>>
>> #include "soc.h"
>> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c
>> index 72565fc..afe1dc9 100644
>> --- a/arch/arm/plat-omap/dmtimer.c
>> +++ b/arch/arm/plat-omap/dmtimer.c
>> @@ -47,7 +47,7 @@
>> #include <linux/platform_device.h>
>> #include <linux/platform_data/dmtimer-omap.h>
>>
>> -#include <plat/dmtimer.h>
>> +#include <clocksource/dmtimer.h>
>>
>> static u32 omap_reserved_systimers;
>> static LIST_HEAD(omap_timer_list);
>> diff --git a/arch/arm/plat-omap/include/plat/dmtimer.h
>> b/include/clocksource/dmtimer.h
>> similarity index 100%
>> rename from arch/arm/plat-omap/include/plat/dmtimer.h
>> rename to include/clocksource/dmtimer.h
>
> Can you fix up the file name and the header guard to appropriate names
> as per the include/clocksource folder convention.
>
> arch/arm/plat-omap/include/plat/dmtimer.h => include/clocksource/dmtimer.h
> and
> __ASM_ARCH_DMTIMER_H => __CLOCKSOURCE_DMTIMER_H
Sure.
>
> I still see this file as OMAP-specific, so should this be renamed to
> dmtimer-omap.h instead of a generic dmtimer.h name?
I will go with ti-dmtimer.c.
>
> regards
> Suman
>
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
next prev parent reply other threads:[~2018-02-14 4:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 6:22 [PATCH v7 0/9] omap: dmtimer: Move driver " Keerthy
2018-01-09 6:22 ` [PATCH v7 1/9] clocksource: dmtimer: Remove all the exports Keerthy
2018-01-09 6:23 ` [PATCH v7 2/9] arm: omap: timer: Wrap the inline functions under OMAP2PLUS define Keerthy
2018-01-09 9:19 ` Sebastian Reichel
2018-01-09 6:23 ` [PATCH v7 3/9] arm: omap: Move dmtimer.h out of plat-omap Keerthy
2018-02-13 2:06 ` Suman Anna
2018-02-13 15:09 ` Tony Lindgren
2018-02-14 4:11 ` Keerthy
2018-02-14 4:50 ` Keerthy [this message]
2018-02-14 18:59 ` Tony Lindgren
2018-01-09 6:23 ` [PATCH v7 4/9] arm: OMAP: Move dmtimer driver out of plat-omap to drivers under clocksource Keerthy
2018-02-13 2:24 ` Suman Anna
2018-02-14 5:09 ` Keerthy
2018-01-09 6:23 ` [PATCH v7 5/9] dmtimer: Add timer ops to the platform data structure Keerthy
2018-02-13 2:46 ` Suman Anna
2018-02-14 5:21 ` Keerthy
2018-01-09 6:23 ` [PATCH v7 6/9] clocksource: dmtimer: Populate the timer ops to the pdata Keerthy
2018-01-09 6:23 ` [PATCH v7 7/9] clocksource: timer-dm: Hook device platform data if not already assigned Keerthy
2018-01-09 9:19 ` Sebastian Reichel
2018-01-09 6:23 ` [PATCH v7 8/9] pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops Keerthy
2018-01-09 6:23 ` [PATCH v7 9/9] arm: omap: pdata-quirks: Remove unused timer pdata Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37f28584-20c2-51c1-e476-75ef81f03af6@ti.com \
--to=j-keerthy@ti.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=aaro.koskinen@iki.fi \
--cc=daniel.lezcano@linaro.org \
--cc=grygorii.strashko@ti.com \
--cc=ladis@linux-mips.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
--cc=sebastian.reichel@collabora.co.uk \
--cc=t-kristo@ti.com \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®