mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Jaroslav Kysela <perex@suse.cz>
Cc: Edward Tandi <ed@efix.biz>,
	azarah@nosferatu.za.org, alsa-devel@lists.sourceforge.net,
	Linux Kernel Mailing Lists <linux-kernel@vger.kernel.org>,
	Rob Love <rml@ximian.com>, Andrew Morton <akpm@osdl.org>,
	Stan Bubrouski <stan@ccs.neu.edu>
Subject: Re: OSS sound emulation broken between 2.6.0-test2 and test3
Date: Sat, 27 Dec 2003 12:12:54 -0800	[thread overview]
Message-ID: <3800000.1072555973@[10.10.2.4]> (raw)
In-Reply-To: <Pine.LNX.4.58.0312272050140.25504@pnote.perex-int.cz>

>> --- compile/sound/core/oss/pcm_oss.c.old	Mon Nov 17 18:29:43 2003
>> +++ compile/sound/core/oss/pcm_oss.c	Sat Dec 27 10:32:30 2003
>> @@ -814,7 +814,7 @@
>>  			xfer += tmp;
>>  			if (substream->oss.setup == NULL || !substream->oss.setup->wholefrag ||
>>  			    runtime->oss.buffer_used == runtime->oss.period_bytes) {
>> -				tmp = snd_pcm_oss_write2(substream, runtime->oss.buffer, runtime->oss.buffer_used, 1);
>> +				tmp = snd_pcm_oss_write2(substream, runtime->oss.buffer, runtime->oss.period_bytes, 1);
>>  				if (tmp <= 0)
>>  					return xfer > 0 ? (snd_pcm_sframes_t)xfer : tmp;
>>  				runtime->oss.bytes += tmp;
> 
> It's not a good fix. 

OK you know the code far better than I ... but it sounds a lot better ;-)
So *something* around there is broken. It sounds horrible in 2.6.0 virgin.

> The problem might be that the rate convert plugin is 
> activated. When small chunks are passed to this plugin, the quality drops.
> You can check it with this command (and compare native and OSS rates):
> 
>   cat /proc/asound/card0/pcm0p/sub0/*

OSS rate: 44100
rate: 48000 (48000/1)

However, test2 worked fine - and it works fine with whole-frag turned on ...
has the rate conversion changed?

> Also, we fixed some OSS emulation errors in our latest code which is 
> available here:
> 
>   bk pull http://linux-sound.bkbits.net/linux-sound
> 
> or
> 
>   ftp://ftp.alsa-project.org/pub/kernel-patches/alsa-bk-2003-12-05.patch.gz
> 
> I will prepare new patch for recent kernel soon.

I tried the above patch - doesn't help.

Thanks,

M.


  reply	other threads:[~2003-12-27 20:24 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-26 21:55 2.6.0 sound output - wierd effects Martin J. Bligh
2003-12-26 22:27 ` Sven-Haegar Koch
2003-12-27 16:14   ` Martin J. Bligh
2003-12-26 22:52 ` Martin Schlemmer
2003-12-26 23:00   ` Martin J. Bligh
2003-12-26 23:17     ` Martin Schlemmer
2003-12-26 23:24       ` Martin J. Bligh
2003-12-26 23:50         ` Martin Schlemmer
2003-12-26 23:59           ` Martin J. Bligh
2003-12-27  0:44             ` Martin Schlemmer
2003-12-27  0:53             ` Martin Schlemmer
2003-12-27  4:34               ` Martin J. Bligh
2003-12-27 11:12                 ` Martin Schlemmer
2003-12-27 16:17                   ` Martin J. Bligh
2003-12-27  4:48             ` Stan Bubrouski
2003-12-27  4:57               ` Rob Love
2003-12-27  5:02                 ` Martin J. Bligh
2003-12-27  5:10                   ` Rob Love
2003-12-27  5:45                     ` Stan Bubrouski
2003-12-27 22:44                     ` szonyi calin
2003-12-27  7:50               ` OSS sound emulation broken between 2.6.0-test2 and test3 Martin J. Bligh
2003-12-27 11:11                 ` Martin Schlemmer
2003-12-27 11:44                   ` Edward Tandi
2003-12-27 12:24                     ` Martin Schlemmer
2003-12-27 13:08                       ` Edward Tandi
2003-12-27 14:33                         ` Martin Schlemmer
2003-12-27 16:55                           ` Edward Tandi
2003-12-27 17:22                             ` Martin Schlemmer
2003-12-27 21:56                             ` Henrik Storner
2003-12-27 22:51                               ` Edward Tandi
2003-12-27 18:35                     ` Martin J. Bligh
2003-12-27 19:56                       ` Jaroslav Kysela
2003-12-27 20:12                         ` Martin J. Bligh [this message]
2003-12-27 20:25                       ` Martin Schlemmer
2003-12-27 20:44                         ` Martin Schlemmer
2003-12-28  0:27                           ` Martin J. Bligh
2004-01-03  0:53                     ` Chris Shafer
2004-01-03 22:23                       ` Martin Schlemmer
2003-12-28  5:06                 ` Joshua Schmidlkofer
2003-12-26 22:59 ` 2.6.0 sound output - wierd effects Sander Sweers
2003-12-26 23:02   ` Martin J. Bligh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='3800000.1072555973@[10.10.2.4]' \
    --to=mbligh@aracnet.com \
    --cc=akpm@osdl.org \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=azarah@nosferatu.za.org \
    --cc=ed@efix.biz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    --cc=rml@ximian.com \
    --cc=stan@ccs.neu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®