From: "Martin J. Bligh" <mbligh@mbligh.org>
To: Andrew Morton <akpm@osdl.org>
Cc: chrisw@osdl.org, linux-kernel@vger.kernel.org,
Zachary Amsden <zach@vmware.com>
Subject: Re: [PATCH] abstract out bits of ldt.c
Date: Sun, 07 Aug 2005 17:59:59 -0700 [thread overview]
Message-ID: <380250000.1123462799@[10.10.2.4]> (raw)
In-Reply-To: <20050807174129.20c7202f.akpm@osdl.org>
--Andrew Morton <akpm@osdl.org> wrote (on Sunday, August 07, 2005 17:41:29 -0700):
> "Martin J. Bligh" <mbligh@mbligh.org> wrote:
>>
>>
>>
>> --Chris Wright <chrisw@osdl.org> wrote (on Sunday, August 07, 2005 16:44:11 -0700):
>>
>> > * Martin J. Bligh (mbligh@mbligh.org) wrote:
>> >> Starting on the work to merge xen cleanly as a subarch.
>> >> Introduce make_pages_readonly and make_pages_writable where appropriate
>> >> for Xen, defined as a no-op on other subarches. Same for
>> >
>> > Maybe this is a bad name, since make_pages_readonly/writable has
>> > intutitive meaning, and then is non-inutitively a no-op (for default).
>>
>> You're welcome to suggest something else if you want, though it would
>> have been easier if you'd done it the first time you saw this patch,
>> not now. Going through this stuff multiple times is going to get very
>> boring very fast.
>>
>> xen_make_pages_readonly / xen_make_pages_writable ?
>>
>
> Well we don't want to assume "xen" at this stage. We're faced with a
> choice at present: to make the linux->hypervisor interface be some
> xen-specific and xen-controlled thing, or to make it a more formal and
> controlled kernel interface which talks to a generic hypervisor rather than
> assuming it's Xen down there.
Yes, more generic than xen would be better. I think mach-xen is probably
OK for now, but I agree we should avoid wedging xen_* in generic code
callouts. What I'm trying to do right now is rip the whole duplicated
files out of the xen patches.
> As long as it doesn't hamper performance or general code sanity, I think it
> would be better to make this a well-defined and controlled Linux interface.
> Some of the code to do that is starting to accumulate in -mm. Everyone
> needs to sit down, take a look at the patches and the proposal and work out
> if this is the way to proceed.
We're faced with a difficult choice - the xen patches are hard to read
without refactoring them. On the other hand it's going to be very painful
to keep them in sync out of tree whilst doing the refactoring. I'd prefer
to merge up some bits as we go, though maybe I should keep those more
neutral than this. Sigh ... this is going to be extremely painful whatever
we do.
M.
next prev parent reply other threads:[~2005-08-08 0:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-07 23:20 Martin J. Bligh
2005-08-07 23:44 ` Chris Wright
2005-08-07 23:57 ` Martin J. Bligh
2005-08-07 23:59 ` Chris Wright
2005-08-08 0:41 ` Andrew Morton
2005-08-08 0:46 ` Chris Wright
2005-08-08 1:04 ` Zachary Amsden
2005-08-08 1:08 ` Chris Wright
2005-08-08 1:16 ` Zachary Amsden
2005-08-08 1:36 ` Chris Wright
2005-08-08 1:21 ` Martin J. Bligh
2005-08-08 0:59 ` Martin J. Bligh [this message]
[not found] ` <20050808113014.GA15165@elte.hu>
[not found] ` <20050808095755.23810b15.akpm@osdl.org>
2005-08-09 9:23 ` Ingo Molnar
2005-08-09 9:28 ` Christoph Hellwig
2005-08-08 8:41 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='380250000.1123462799@[10.10.2.4]' \
--to=mbligh@mbligh.org \
--cc=akpm@osdl.org \
--cc=chrisw@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®