mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Martin J. Bligh" <mbligh@mbligh.org>
To: Zachary Amsden <zach@vmware.com>, Chris Wright <chrisw@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org,
	Pratap Subrahmanyam <pratap@vmware.com>
Subject: Re: [PATCH] abstract out bits of ldt.c
Date: Sun, 07 Aug 2005 18:21:49 -0700	[thread overview]
Message-ID: <383160000.1123464108@[10.10.2.4]> (raw)
In-Reply-To: <42F6AF8E.60107@vmware.com>

> I like these patches.  They greatly simplify a lot of the work I 
> had anticipated was necessary for Xen.  I.e. - LDT / GDT accessors 
> are not needed for most updates, only updates to live descriptor 
> table entries (for GDT this is TLS, LDT, TSS?, entries and there 
> is 1 LDT update case).

I'm just trying to get rid of as much code duplication as possible.

> BTW, Martin, did you see my ldt-accessors patch?  It also 
> encapsulates that 1 LDT update case you show here, just named 
> differently.

I was focussing on creating a whole Xen stack before looking at
your stuff much, then seeing what was common between them, as I
think it's a bit hard to read the current Xen code because of the
copied files. Unfortunately, is going to be harder then I thought
to maintain that stack out of tree, so I wanted to shovel out
the basic refactoring stuff. Then the line got a bit blurred.
Humpf. And this is the easy part. Damn it.

Doing the whole thing and comparing is going to be a total PITA.
Perhaps the right thing to do is go one file at a time, and sync
up on that basis.

> Yours:
> 
> +static inline int install_ldt_entry (__u32 *lp, __u32 entry_1, __u32 entry_2)
> +{
> +	*lp     = entry_1;
> +	*(lp+1) = entry_2;
> +	return 0;
> +}
> 
> Mine:
> 
> +static inline void write_ldt_entry(void *ldt, int entry, __u32 entry_a, __u32 entry_b)
> +{
> +	__u32 *lp = (__u32 *)((char *)ldt + entry*8);
> +	*lp = entry_a;
> +	*(lp+1) = entry_b;
> +}
> 
> 
> They both work, but mine does not assume page aligned LDTs (necessary 
> to extract entry number).  This is moot right now because LDTs are 
> page aligned anyway in Linux.  I actually don't care which one we 
> use, but it might be even nicer if we got one with C type checking 
> (struct desc_struct for ldt).

Heh, is similar, considering we're working from completely different
angles. I'm just refactoring the current code without changing it
too much at first, we can make it more robust later. otherwise it's
going to be a pig to review if we mix those up.

> I think introducing mach-xen headers is a bit premature though - lets 
> get the interface nailed down first so that the hypervisor developers 
> have time to settle the include/asm-i386/mach-xxx files without 
> dealing unneeded churn onto the maintainers.

I can easily leave those bits out. There's going to be lots of bits common
with std i386, and bits that are common amongst the hypervisor layers,
then bits that are specific. Hopefully more bits that are common, but
still.

Humpf. I shall go back into my corner and have a rethink. Will read through
your patches some more, then send you some email.

M.

  parent reply	other threads:[~2005-08-08  1:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-07 23:20 Martin J. Bligh
2005-08-07 23:44 ` Chris Wright
2005-08-07 23:57   ` Martin J. Bligh
2005-08-07 23:59     ` Chris Wright
2005-08-08  0:41     ` Andrew Morton
2005-08-08  0:46       ` Chris Wright
2005-08-08  1:04         ` Zachary Amsden
2005-08-08  1:08           ` Chris Wright
2005-08-08  1:16             ` Zachary Amsden
2005-08-08  1:36               ` Chris Wright
2005-08-08  1:21           ` Martin J. Bligh [this message]
2005-08-08  0:59       ` Martin J. Bligh
     [not found]       ` <20050808113014.GA15165@elte.hu>
     [not found]         ` <20050808095755.23810b15.akpm@osdl.org>
2005-08-09  9:23           ` Ingo Molnar
2005-08-09  9:28             ` Christoph Hellwig
2005-08-08  8:41 ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='383160000.1123464108@[10.10.2.4]' \
    --to=mbligh@mbligh.org \
    --cc=akpm@osdl.org \
    --cc=chrisw@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pratap@vmware.com \
    --cc=zach@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®