mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: TW <dalzot@gmail.com>, Thorsten Leemhuis <regressions@leemhuis.info>
Cc: regressions@lists.linux.dev,
	Mario Limonciello <mario.limonciello@amd.com>,
	Bart Van Assche <bvanassche@acm.org>,
	LKML <linux-kernel@vger.kernel.org>,
	stable@vger.kernel.org
Subject: Re: Scsi_bus_resume+0x0/0x90 returns -5 when resuming from s3 sleep
Date: Fri, 28 Jul 2023 13:09:06 +0900	[thread overview]
Message-ID: <3836423e-8f0f-1278-38e5-d35fbd7298e4@kernel.org> (raw)
In-Reply-To: <d44e4057-0758-4cb8-ca29-02b5bb340b8b@gmail.com>

On 7/28/23 11:49, TW wrote:
> Comparing to the 5.15 kernel which had almost no delay. They are HDDs 
> though, it was working flawlessly earlier but didn't want to top post 
> again. Tried a systemd suspend instead of from the Xfce4 logout menu and 
> everything works as intended. So I'd say that it's fixed now.

I think that asynchronous scsi suspend/resume using the PM infrastructure,
introduced in 5.16, is creating this additional delay. The reason is that now,
ata and scsi drivers do their resume operations from within the PM resume
process, resulting in some delays to reach "PM: suspend exit".

I am looking into improving this, but it may take some more time.

I will post officially the patch you tried and CC you. A "tested-by" tag from
you would be appreciated.

Thanks.

> 
> On 7/27/23 20:33, Damien Le Moal wrote:
>> "Slow coming back" -> Compared to which version of the kernel ? Do you 
>> have numbers ? If the devices are HDDs, resume will wait for these to 
>> spin up. That takes a while (about 10s normally).

-- 
Damien Le Moal
Western Digital Research


  reply	other threads:[~2023-07-28  4:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0e272abe-292d-d58f-cf80-55868e793abc@gmail.com>
2023-07-26 13:47 ` Thorsten Leemhuis
2023-07-26 23:39   ` Damien Le Moal
2023-07-27 10:06     ` TW
2023-07-27 10:22       ` TW
2023-07-27 10:25         ` Damien Le Moal
2023-07-27 10:27         ` Damien Le Moal
2023-07-27 12:25           ` TW
2023-07-28  2:33             ` Damien Le Moal
2023-07-28  2:49               ` TW
2023-07-28  4:09                 ` Damien Le Moal [this message]
2023-07-31  0:41                 ` Damien Le Moal
2023-07-31  3:47                   ` TW
2023-07-27 10:24       ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3836423e-8f0f-1278-38e5-d35fbd7298e4@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=bvanassche@acm.org \
    --cc=dalzot@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®