mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Haigh <netwiz@crc.id.au>
To: Juergen Gross <jgross@suse.com>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
	roger.pau@citrix.com
Subject: Re: [PATCH 0/3] xen/blkback: several fixes of resource management
Date: Thu, 18 May 2017 11:55:14 +1000	[thread overview]
Message-ID: <384b0102e3a0c612b14838154aa7fb9c@crc.id.au> (raw)
In-Reply-To: <20170516062320.22008-1-jgross@suse.com>

On 2017-05-16 16:23, Juergen Gross wrote:
> Destroying a Xen guest domain while it was doing I/Os via xen-blkback
> leaked several resources, including references of the guest's memory
> pages.
> 
> This patch series addresses those leaks by correcting usage of
> reference counts and the sequence when to free which resource.
> 
> The series applies on top of commit 2d4456c73a487abe ("block:
> xen-blkback: add null check to avoid null pointer dereference") in
> Jens Axboe's tree kernel/git/axboe/linux-block.git
> 
> Juergen Gross (3):
>   xen/blkback: fix disconnect while I/Os in flight
>   xen/blkback: don't free be structure too early
>   xen/blkback: don't use xen_blkif_get() in xen-blkback kthread
> 
>  drivers/block/xen-blkback/blkback.c |  3 ---
>  drivers/block/xen-blkback/common.h  |  1 +
>  drivers/block/xen-blkback/xenbus.c  | 15 ++++++++-------
>  3 files changed, 9 insertions(+), 10 deletions(-)

Tested-by: Steven Haigh <netwiz@crc.id.au>

I've had a report that a new message is logged on destroy sometimes:
vif vif-1-0 vif1.0: Guest Rx stalled

This may be a different issue - however the main fix of this patch set 
is fully functional.

-- 
Steven Haigh

Email: netwiz@crc.id.au
Web: https://www.crc.id.au
Phone: (03) 9001 6090 - 0412 935 897

  parent reply	other threads:[~2017-05-18  2:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-16  6:23 Juergen Gross
2017-05-16  6:23 ` [PATCH 1/3] xen/blkback: fix disconnect while I/Os in flight Juergen Gross
2017-05-16  9:28   ` [Xen-devel] " Dietmar Hahn
2017-05-16  6:23 ` [PATCH 2/3] xen/blkback: don't free be structure too early Juergen Gross
2017-05-16  6:23 ` [PATCH 3/3] xen/blkback: don't use xen_blkif_get() in xen-blkback kthread Juergen Gross
2017-05-18  1:55 ` Steven Haigh [this message]
2017-05-18 14:38 ` [PATCH 0/3] xen/blkback: several fixes of resource management Roger Pau Monné
2017-05-18 15:04   ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=384b0102e3a0c612b14838154aa7fb9c@crc.id.au \
    --to=netwiz@crc.id.au \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®