From: Jie Luo <quic_luoj@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: <agross@kernel.org>, <konrad.dybcio@linaro.org>,
<mturquette@baylibre.com>, <sboyd@kernel.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>, <catalin.marinas@arm.com>,
<will@kernel.org>, <p.zabel@pengutronix.de>,
<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<quic_srichara@quicinc.com>
Subject: Re: [PATCH v4 3/4] clk: qcom: common: add _qcom_cc_really_probe
Date: Sat, 19 Aug 2023 14:21:37 +0800 [thread overview]
Message-ID: <38627095-a92d-ea8b-56b6-7a4440fb6635@quicinc.com> (raw)
In-Reply-To: <4n3vqstyhknanmzx4swwjg4ueaqq2tbrxadnyrx3bchffyf7qr@yh4bik4rfsgm>
On 8/19/2023 10:54 AM, Bjorn Andersson wrote:
> On Fri, Aug 18, 2023 at 04:35:52PM +0800, Jie Luo wrote:
>> On 8/18/2023 11:14 AM, Bjorn Andersson wrote:
>>> On Tue, Aug 15, 2023 at 04:52:04PM +0800, Luo Jie wrote:
> [..]
>>>> +int qcom_cc_really_probe(struct platform_device *pdev,
>>>> + const struct qcom_cc_desc *desc, struct regmap *regmap)
>>>
>>> Why do we want to keep this wrapper around?
>>>
>> There are many existed clock controller drivers using this wrapper
>> qcom_cc_really_probe, so i still keep this wrapper.
>>
>> do we need to remove this wrapper and update the existed drivers to use
>> _qcom_cc_really_probe?
>
> Yes please. The additional API does not add value, but can be confusing,
> so let's invest the extra time in fixing up all the drivers to keep the
> interface clean.
>
> Regards,
> Bjorn
Thanks Bjorn for the suggestion, will update this patch in the next version.
next prev parent reply other threads:[~2023-08-19 6:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 8:52 [PATCH v4 0/4] add clock controller of qca8386/qca8084 Luo Jie
2023-08-15 8:52 ` [PATCH v4 1/4] clk: qcom: branch: Add clk_branch2_mdio_ops Luo Jie
2023-08-18 3:29 ` Bjorn Andersson
2023-08-18 8:20 ` Jie Luo
2023-08-15 8:52 ` [PATCH v4 2/4] dt-bindings: clock: add qca8386/qca8084 clock and reset definitions Luo Jie
2023-08-15 9:15 ` Krzysztof Kozlowski
2023-08-16 9:12 ` Jie Luo
2023-08-15 8:52 ` [PATCH v4 3/4] clk: qcom: common: add _qcom_cc_really_probe Luo Jie
2023-08-18 3:14 ` Bjorn Andersson
2023-08-18 8:35 ` Jie Luo
2023-08-19 2:54 ` Bjorn Andersson
2023-08-19 6:21 ` Jie Luo [this message]
2023-08-15 8:52 ` [PATCH v4 4/4] clk: qcom: add clock controller driver for qca8386/qca8084 Luo Jie
2023-08-18 3:55 ` Bjorn Andersson
2023-08-18 14:06 ` Jie Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38627095-a92d-ea8b-56b6-7a4440fb6635@quicinc.com \
--to=quic_luoj@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_srichara@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®