From: Jie Luo <quic_luoj@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: <agross@kernel.org>, <konrad.dybcio@linaro.org>,
<mturquette@baylibre.com>, <sboyd@kernel.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>, <catalin.marinas@arm.com>,
<will@kernel.org>, <p.zabel@pengutronix.de>,
<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<quic_srichara@quicinc.com>
Subject: Re: [PATCH v4 3/4] clk: qcom: common: add _qcom_cc_really_probe
Date: Fri, 18 Aug 2023 16:35:52 +0800 [thread overview]
Message-ID: <6ee2129b-04c6-4978-03d6-835e3a10e665@quicinc.com> (raw)
In-Reply-To: <2dcu7jjwd2bhjbzxrxbfif566nupznb5n4oadnqha4h45w2n2g@4uy2pxkj5bvj>
On 8/18/2023 11:14 AM, Bjorn Andersson wrote:
> On Tue, Aug 15, 2023 at 04:52:04PM +0800, Luo Jie wrote:
>> Add the common function _qcom_cc_really_probe, which takes
>> struct device as parameter.
>
> This commit message completely fails to describe the problem/issue the
> change is solving. So when we look back in the git history, there will
> be no indication of why things looks like they do.
>
Thanks for the comments, i will update the commit message in detail on
the issue resolved in the next patch set.
>>
>> Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
>> ---
>> drivers/clk/qcom/common.c | 10 ++++++++--
>> drivers/clk/qcom/common.h | 2 ++
>> 2 files changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c
>> index 75f09e6e057e..4cbdbfb65606 100644
>> --- a/drivers/clk/qcom/common.c
>> +++ b/drivers/clk/qcom/common.c
>> @@ -234,11 +234,10 @@ static struct clk_hw *qcom_cc_clk_hw_get(struct of_phandle_args *clkspec,
>> return cc->rclks[idx] ? &cc->rclks[idx]->hw : NULL;
>> }
>>
>> -int qcom_cc_really_probe(struct platform_device *pdev,
>> +int _qcom_cc_really_probe(struct device *dev,
>> const struct qcom_cc_desc *desc, struct regmap *regmap)
>> {
>> int i, ret;
>> - struct device *dev = &pdev->dev;
>> struct qcom_reset_controller *reset;
>> struct qcom_cc *cc;
>> struct gdsc_desc *scd;
>> @@ -305,6 +304,13 @@ int qcom_cc_really_probe(struct platform_device *pdev,
>>
>> return 0;
>> }
>> +EXPORT_SYMBOL_GPL(_qcom_cc_really_probe);
>> +
>> +int qcom_cc_really_probe(struct platform_device *pdev,
>> + const struct qcom_cc_desc *desc, struct regmap *regmap)
>
> Why do we want to keep this wrapper around?
>
There are many existed clock controller drivers using this wrapper
qcom_cc_really_probe, so i still keep this wrapper.
do we need to remove this wrapper and update the existed drivers to use
_qcom_cc_really_probe?
>
> PS. Please give some time before posting v5, I would like to understand
> the MDIO regmap operations in patch 4 better before commenting on it.
>
> Regards,
> Bjorn
>
Sure, the MDIO read/write operations need to check whether the MDIO bus
is in busy state, the poll and sleep are taken to check.
Thanks Bjorn for your time and review comments.
>> +{
>> + return _qcom_cc_really_probe(&pdev->dev, desc, regmap);
>> +}
>> EXPORT_SYMBOL_GPL(qcom_cc_really_probe);
>>
>> int qcom_cc_probe(struct platform_device *pdev, const struct qcom_cc_desc *desc)
>> diff --git a/drivers/clk/qcom/common.h b/drivers/clk/qcom/common.h
>> index 9c8f7b798d9f..9710ade9bf15 100644
>> --- a/drivers/clk/qcom/common.h
>> +++ b/drivers/clk/qcom/common.h
>> @@ -58,6 +58,8 @@ extern int qcom_cc_register_sleep_clk(struct device *dev);
>>
>> extern struct regmap *qcom_cc_map(struct platform_device *pdev,
>> const struct qcom_cc_desc *desc);
>> +extern int _qcom_cc_really_probe(struct device *dev,
>> + const struct qcom_cc_desc *desc, struct regmap *regmap);
>> extern int qcom_cc_really_probe(struct platform_device *pdev,
>> const struct qcom_cc_desc *desc,
>> struct regmap *regmap);
>> --
>> 2.17.1
>>
next prev parent reply other threads:[~2023-08-18 8:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 8:52 [PATCH v4 0/4] add clock controller of qca8386/qca8084 Luo Jie
2023-08-15 8:52 ` [PATCH v4 1/4] clk: qcom: branch: Add clk_branch2_mdio_ops Luo Jie
2023-08-18 3:29 ` Bjorn Andersson
2023-08-18 8:20 ` Jie Luo
2023-08-15 8:52 ` [PATCH v4 2/4] dt-bindings: clock: add qca8386/qca8084 clock and reset definitions Luo Jie
2023-08-15 9:15 ` Krzysztof Kozlowski
2023-08-16 9:12 ` Jie Luo
2023-08-15 8:52 ` [PATCH v4 3/4] clk: qcom: common: add _qcom_cc_really_probe Luo Jie
2023-08-18 3:14 ` Bjorn Andersson
2023-08-18 8:35 ` Jie Luo [this message]
2023-08-19 2:54 ` Bjorn Andersson
2023-08-19 6:21 ` Jie Luo
2023-08-15 8:52 ` [PATCH v4 4/4] clk: qcom: add clock controller driver for qca8386/qca8084 Luo Jie
2023-08-18 3:55 ` Bjorn Andersson
2023-08-18 14:06 ` Jie Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ee2129b-04c6-4978-03d6-835e3a10e665@quicinc.com \
--to=quic_luoj@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_srichara@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®