From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v2 3/3] Input: qt1070 - Add OF device ID table
Date: Thu, 23 Mar 2017 16:14:56 -0300 [thread overview]
Message-ID: <387639b5-01f4-2ba7-3065-5679571c08db@osg.samsung.com> (raw)
In-Reply-To: <20170222144005.23447-3-javier@osg.samsung.com>
Hello Dmitry,
On 02/22/2017 11:40 AM, Javier Martinez Canillas wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
>
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
>
> The compatible strings don't have a vendor prefix because that's how it's
> used currently, and changing this will be a Device Tree ABI break.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
What's your decision about this patch series?
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2017-03-23 19:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 14:40 [PATCH v2 1/3] Input: silead " Javier Martinez Canillas
2017-02-22 14:40 ` [PATCH v2 2/3] Input: synaptics_i2c " Javier Martinez Canillas
2017-02-22 14:40 ` [PATCH v2 3/3] Input: qt1070 " Javier Martinez Canillas
2017-03-23 19:14 ` Javier Martinez Canillas [this message]
2017-03-23 21:45 ` Dmitry Torokhov
2017-03-27 15:16 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=387639b5-01f4-2ba7-3065-5679571c08db@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®