[RFC PATCH] delete unnecessary BUG_ON !policy->cur

[RFC PATCH] delete unnecessary BUG_ON !policy->cur

[Luming Yu]

Hi there,

When testing upstream Git tree, there is a BUG_ON hit on a IA64 system
with RHEL 5 user space installed.
Please review the patch below, If make sense, please apply.

Ps. The patch is enclosed in attachment. The inlined one
is c&p of it for reading.


Thanks,
Luming

Signed-off-by: Yu Luming <luming.yu@intel.com>

 cpufreq_userspace.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/cpufreq/cpufreq_userspace.c
b/drivers/cpufreq/cpufreq_userspace.c
index 66d2d1d..63bd232 100644
--- a/drivers/cpufreq/cpufreq_userspace.c
+++ b/drivers/cpufreq/cpufreq_userspace.c
@@ -119,7 +119,6 @@ static int cpufreq_governor_userspace(st
 	case CPUFREQ_GOV_START:
 		if (!cpu_online(cpu))
 			return -EINVAL;
-		BUG_ON(!policy->cur);
 		mutex_lock(&userspace_mutex);

 		if (cpus_using_userspace_governor == 0) {

Re: [RFC PATCH] delete unnecessary BUG_ON !policy->cur

[Luming Yu]

[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]

Patch attached!

On Tue, Sep 22, 2009 at 3:17 PM, Luming Yu <luming.yu@gmail.com> wrote:
> Hi there,
>
> When testing upstream Git tree, there is a BUG_ON hit on a IA64 system
> with RHEL 5 user space installed.
> Please review the patch below, If make sense, please apply.
>
> Ps. The patch is enclosed in attachment. The inlined one
> is c&p of it for reading.
>
>
> Thanks,
> Luming
>
> Signed-off-by: Yu Luming <luming.yu@intel.com>
>
>  cpufreq_userspace.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cpufreq_userspace.c
> b/drivers/cpufreq/cpufreq_userspace.c
> index 66d2d1d..63bd232 100644
> --- a/drivers/cpufreq/cpufreq_userspace.c
> +++ b/drivers/cpufreq/cpufreq_userspace.c
> @@ -119,7 +119,6 @@ static int cpufreq_governor_userspace(st
>        case CPUFREQ_GOV_START:
>                if (!cpu_online(cpu))
>                        return -EINVAL;
> -               BUG_ON(!policy->cur);
>                mutex_lock(&userspace_mutex);
>
>                if (cpus_using_userspace_governor == 0) {
>

[-- Attachment #2: 10.patch --]
[-- Type: application/octet-stream, Size: 438 bytes --]

diff --git a/drivers/cpufreq/cpufreq_userspace.c b/drivers/cpufreq/cpufreq_userspace.c
index 66d2d1d..63bd232 100644
--- a/drivers/cpufreq/cpufreq_userspace.c
+++ b/drivers/cpufreq/cpufreq_userspace.c
@@ -119,7 +119,6 @@ static int cpufreq_governor_userspace(st
 	case CPUFREQ_GOV_START:
 		if (!cpu_online(cpu))
 			return -EINVAL;
-		BUG_ON(!policy->cur);
 		mutex_lock(&userspace_mutex);
 
 		if (cpus_using_userspace_governor == 0) {