From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Anjandev Momi <anjan@momi.ca>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] Staging: rtl8192e: make alignment match open parenthesis
Date: Fri, 14 Oct 2022 21:00:50 +0200 [thread overview]
Message-ID: <38990e85-b74f-0910-8d64-ad614c3bd8e4@gmail.com> (raw)
In-Reply-To: <20221014081839.23902-4-anjan@momi.ca>
On 10/14/22 10:18, Anjandev Momi wrote:
> This patch removes the following checks generated by checkpatch.pl:
>
> ./drivers/staging/rtl8192e/rtl819x_BAProc.c:261: CHECK:
> Alignment should match open parenthesis
> ./drivers/staging/rtl8192e/rtl819x_BAProc.c:284: CHECK:
> Alignment should match open parenthesis
> ./drivers/staging/rtl8192e/rtl819x_BAProc.c:421: CHECK:
> Alignment should match open parenthesis
> ./drivers/staging/rtl8192e/rtl819x_BAProc.c:441: CHECK:
> Alignment should match open parenthesis
>
> Signed-off-by: Anjandev Momi <anjan@momi.ca>
> ---
> drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index f36c24c2a..8d92b3426 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -258,7 +258,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
> goto OnADDBAReq_Fail;
> }
> if (!GetTs(ieee, (struct ts_common_info **)&pTS, dst,
> - (u8)(pBaParamSet->field.tid), RX_DIR, true)) {
> + (u8)(pBaParamSet->field.tid), RX_DIR, true)) {
> rc = ADDBA_STATUS_REFUSED;
> netdev_warn(ieee->dev, "%s(): can't get TS\n", __func__);
> goto OnADDBAReq_Fail;
> @@ -281,7 +281,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
> pBA->ba_start_seq_ctrl = *pBaStartSeqCtrl;
>
> if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev) ||
> - (ieee->pHTInfo->IOTAction & HT_IOT_ACT_ALLOW_PEER_AGG_ONE_PKT))
Did a git pull 2 hours ago.
Cannot apply this patch because IOTAction was already renamed.
Bye Philipp
> + (ieee->pHTInfo->IOTAction & HT_IOT_ACT_ALLOW_PEER_AGG_ONE_PKT))
> pBA->ba_param_set.field.buffer_size = 1;
> else
> pBA->ba_param_set.field.buffer_size = 32;
> @@ -418,7 +418,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb)
> }
>
> if (!ieee->current_network.qos_data.active ||
> - !ieee->pHTInfo->bCurrentHTSupport) {
> + !ieee->pHTInfo->bCurrentHTSupport) {
> netdev_warn(ieee->dev,
> "received DELBA while QOS or HT is not supported(%d, %d)\n",
> ieee->current_network. qos_data.active,
> @@ -438,7 +438,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb)
> struct rx_ts_record *pRxTs;
>
> if (!GetTs(ieee, (struct ts_common_info **)&pRxTs, dst,
> - (u8)pDelBaParamSet->field.tid, RX_DIR, false)) {
> + (u8)pDelBaParamSet->field.tid, RX_DIR, false)) {
> netdev_warn(ieee->dev,
> "%s(): can't get TS for RXTS. dst:%pM TID:%d\n",
> __func__, dst,
next prev parent reply other threads:[~2022-10-14 19:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 8:18 [PATCH 0/4 v3] Staging: rtl8192e: fix coding style issues Anjandev Momi
2022-10-14 8:18 ` [PATCH 1/4] Staging: rtl8192e: remove unnecessary parentheses Anjandev Momi
2022-10-14 8:18 ` [PATCH 2/4] Staging: rtl8192e: remove multiple blank lines Anjandev Momi
2022-10-14 8:18 ` [PATCH 3/4] Staging: rtl8192e: make alignment match open parenthesis Anjandev Momi
2022-10-14 19:00 ` Philipp Hortmann [this message]
2022-10-14 8:18 ` [PATCH 4/4] Staging: rtl8192e: add blank line after function declaration Anjandev Momi
-- strict thread matches above, loose matches on Subject: below --
2022-09-22 7:59 [PATCH 0/4 v2] Staging: rtl8192e: fix coding style issues Anjandev Momi
2022-09-22 7:59 ` [PATCH 3/4] Staging: rtl8192e: make alignment match open parenthesis Anjandev Momi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38990e85-b74f-0910-8d64-ad614c3bd8e4@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=anjan@momi.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®