From: Eddie James <eajames@linux.ibm.com>
To: "Rob Herring (Arm)" <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Ninad Palsule <ninad@linux.ibm.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-fsi@lists.ozlabs.org
Subject: Re: [PATCH 2/6] ARM: dts: aspeed: Drop "fsi-master" compatibles
Date: Fri, 1 Aug 2025 09:57:34 -0500 [thread overview]
Message-ID: <38a495ea-57c0-4348-aacd-fdebb25480d7@linux.ibm.com> (raw)
In-Reply-To: <20250731-dt-fsi-cleanups-v1-2-e7b695a29fc3@kernel.org>
On 7/31/25 17:12, Rob Herring (Arm) wrote:
> The "fsi-master" compatible has been used inconsistently on FSI masters.
> It doesn't have any real use or meaning, so it's easier to drop it
> everywhere than add it where missing. It is also not documented by any
> schemas (only .txt bindings).
Acked-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts | 2 +-
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts | 2 +-
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-mowgli.dts | 2 +-
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts | 2 +-
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-palmetto.dts | 2 +-
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts | 2 +-
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-swift.dts | 2 +-
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-witherspoon.dts | 2 +-
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-zaius.dts | 2 +-
> arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 4 ++--
> 10 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
> index f42254ba6aeb..79c6919b3570 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-inspur-fp5280g2.dts
> @@ -54,7 +54,7 @@ video_engine_memory: jpegbuffer {
> };
>
> fsi: gpio-fsi {
> - compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
> + compatible = "aspeed,ast2500-cf-fsi-master";
> #address-cells = <2>;
> #size-cells = <0>;
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts
> index 370738572a55..87acbfc0a1b7 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts
> @@ -63,7 +63,7 @@ sys_err {
> };
>
> fsi: gpio-fsi {
> - compatible = "fsi-master-gpio", "fsi-master";
> + compatible = "fsi-master-gpio";
> #address-cells = <2>;
> #size-cells = <0>;
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-mowgli.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-mowgli.dts
> index 31ff19ef87a0..6c8b966ffccc 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-mowgli.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-mowgli.dts
> @@ -165,7 +165,7 @@ fan4 {
> };
>
> fsi: gpio-fsi {
> - compatible = "fsi-master-gpio", "fsi-master";
> + compatible = "fsi-master-gpio";
> #address-cells = <2>;
> #size-cells = <0>;
> no-gpio-delays;
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
> index e5b8d07e7622..1b7c25e307bc 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dts
> @@ -77,7 +77,7 @@ attention {
> };
>
> fsi: gpio-fsi {
> - compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
> + compatible = "aspeed,ast2500-cf-fsi-master";
> #address-cells = <2>;
> #size-cells = <0>;
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-palmetto.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-palmetto.dts
> index 45631b47a7b3..c7aa14034dc0 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-palmetto.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-palmetto.dts
> @@ -55,7 +55,7 @@ identify {
> };
>
> fsi: gpio-fsi {
> - compatible = "aspeed,ast2400-cf-fsi-master", "fsi-master";
> + compatible = "aspeed,ast2400-cf-fsi-master";
> #address-cells = <2>;
> #size-cells = <0>;
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
> index 2180fa9b6f24..3c03204869e7 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dts
> @@ -68,7 +68,7 @@ power {
> };
>
> fsi: gpio-fsi {
> - compatible = "aspeed,ast2500-cf-fsi-master", "fsi-master";
> + compatible = "aspeed,ast2500-cf-fsi-master";
> #address-cells = <2>;
> #size-cells = <0>;
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-swift.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-swift.dts
> index a0e8c97e944a..39d0fe46fd9e 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-swift.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-swift.dts
> @@ -200,7 +200,7 @@ rear-id {
> };
>
> fsi: gpio-fsi {
> - compatible = "fsi-master-gpio", "fsi-master";
> + compatible = "fsi-master-gpio";
> #address-cells = <2>;
> #size-cells = <0>;
> no-gpio-delays;
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-witherspoon.dts
> index 8b1e82c8cdfe..89907b628b65 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-witherspoon.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-witherspoon.dts
> @@ -173,7 +173,7 @@ power-button {
> };
>
> fsi: gpio-fsi {
> - compatible = "fsi-master-gpio", "fsi-master";
> + compatible = "fsi-master-gpio";
> #address-cells = <2>;
> #size-cells = <0>;
> no-gpio-delays;
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-zaius.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-zaius.dts
> index 9904f0a58cfa..9b49b0aa8b35 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-zaius.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-zaius.dts
> @@ -96,7 +96,7 @@ hdd_fault {
> };
>
> fsi: gpio-fsi {
> - compatible = "fsi-master-gpio", "fsi-master";
> + compatible = "fsi-master-gpio";
> #address-cells = <2>;
> #size-cells = <0>;
> no-gpio-delays;
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> index 8ed715bd53aa..acdb6ae74b27 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> @@ -847,7 +847,7 @@ i2c: bus@1e78a000 {
>
> fsim0: fsi@1e79b000 {
> #interrupt-cells = <1>;
> - compatible = "aspeed,ast2600-fsi-master", "fsi-master";
> + compatible = "aspeed,ast2600-fsi-master";
> reg = <0x1e79b000 0x94>;
> interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
> pinctrl-names = "default";
> @@ -859,7 +859,7 @@ fsim0: fsi@1e79b000 {
>
> fsim1: fsi@1e79b100 {
> #interrupt-cells = <1>;
> - compatible = "aspeed,ast2600-fsi-master", "fsi-master";
> + compatible = "aspeed,ast2600-fsi-master";
> reg = <0x1e79b100 0x94>;
> interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
> pinctrl-names = "default";
>
next prev parent reply other threads:[~2025-08-01 14:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 22:12 [PATCH 0/6] ASpeed FSI DT clean-ups Rob Herring (Arm)
2025-07-31 22:12 ` [PATCH 1/6] ARM: dts: aspeed: Drop "no-gpio-delays" Rob Herring (Arm)
2025-08-01 14:56 ` Eddie James
2025-07-31 22:12 ` [PATCH 2/6] ARM: dts: aspeed: Drop "fsi-master" compatibles Rob Herring (Arm)
2025-08-01 14:57 ` Eddie James [this message]
2025-07-31 22:12 ` [PATCH 3/6] ARM: dts: aspeed: Add missing "ibm,spi-fsi" compatibles Rob Herring (Arm)
2025-08-01 14:58 ` Eddie James
2025-07-31 22:12 ` [PATCH 4/6] MAINTAINERS: Add FSI bindings to FSI subsystem entry Rob Herring (Arm)
2025-08-01 14:59 ` Eddie James
2025-07-31 22:12 ` [PATCH 5/6] dt-bindings: fsi: Convert fsi-master-gpio to DT schema Rob Herring (Arm)
2025-08-01 15:01 ` Eddie James
2025-07-31 22:12 ` [PATCH 6/6] dt-bindings: fsi: Convert aspeed,ast2400-cf-fsi-master " Rob Herring (Arm)
2025-08-01 15:03 ` Eddie James
2025-08-04 1:38 ` [PATCH 0/6] ASpeed FSI DT clean-ups Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38a495ea-57c0-4348-aacd-fdebb25480d7@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=andrew@codeconstruct.com.au \
--cc=benh@kernel.crashing.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ninad@linux.ibm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®