From: Paolo Abeni <pabeni@redhat.com>
To: Richard Gobert <richardbgobert@gmail.com>,
Felix Fietkau <nbd@nbd.name>,
netdev@vger.kernel.org, Michal Ostrowski <mostrows@earthlink.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
David Ahern <dsahern@kernel.org>, Simon Horman <horms@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3] net: pppoe: implement GRO/GSO support
Date: Mon, 18 Aug 2025 15:32:15 +0200 [thread overview]
Message-ID: <38c4355b-4570-401e-b520-7ec698b62dd8@redhat.com> (raw)
In-Reply-To: <e01a463b-c52c-4f8a-9477-fd413286e41a@gmail.com>
On 8/18/25 1:22 PM, Richard Gobert wrote:
> Felix Fietkau wrote:
>> On 14.08.25 16:30, Richard Gobert wrote:
>>> I don't think this will be called for PPPoE over GRE packets,
>>> since gre_gso_segment skips everything up to the network header.
>>
>> What's a good solution to this issue? Use the outer network header instead of the inner one when the protocol is PPPoE?
>>
>> - Felix
>
> I don't really have a good solution for this. You could explicitly check
> if the protocol is PPPoE in gre_gso_segment, but that wouldn't be very
> elegant or future-proof.
>
> I think setting skb->inner_network_header in pppoe_gro_complete
> (while not resetting it in inet_gro_complete) wouldn't work since other
> functions assume that skb->inner_network_header is an IP header.
Is PPPoE over GRE really a thing? IOW do we need to care at the GRO
level? FTR, my biased answers are "no" and "no" ;)
/P
prev parent reply other threads:[~2025-08-18 13:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 9:57 Felix Fietkau
2025-08-14 9:00 ` Paolo Abeni
2025-08-14 14:30 ` Richard Gobert
2025-08-15 17:24 ` Felix Fietkau
2025-08-18 11:22 ` Richard Gobert
2025-08-18 13:32 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38c4355b-4570-401e-b520-7ec698b62dd8@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mostrows@earthlink.net \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=richardbgobert@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®