mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sander Vanheule <sander@svanheule.net>
To: "Maíra Canal" <mairacanal@riseup.net>, akpm@linux-foundation.org
Cc: andriy.shevchenko@linux.intel.com, bp@alien8.de,
	dave.hansen@linux.intel.com, elver@google.com,
	gregkh@linuxfoundation.org, hpa@zytor.com,
	linux-kernel@vger.kernel.org, mingo@redhat.com,
	peterz@infradead.org, tglx@linutronix.de, vschneid@redhat.com,
	x86@kernel.org, yury.norov@gmail.com,
	Brendan Higgins <brendanhiggins@google.com>,
	David Gow <davidgow@google.com>
Subject: Re: [PATCH v4 3/5] lib/test: Introduce cpumask KUnit test suite
Date: Wed, 20 Jul 2022 14:47:28 +0200	[thread overview]
Message-ID: <38c839001bbd10f58d12c64d78b5f310ee55f9aa.camel@svanheule.net> (raw)
In-Reply-To: <346cb279-8e75-24b0-7d12-9803f2b41c73@riseup.net>

Hi,

On Tue, 2022-07-19 at 18:31 -0300, Maíra Canal wrote:
> > Add a basic suite of tests for cpumask, providing some tests for empty
> > and completely filled cpumasks.
> > 
> > Signed-off-by: Sander Vanheule <sander@svanheule.net>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> The tests test_cpumask_weight and test_cpumask_last are failing on all
> architectures, as can be seen on [1]. Also this test doesn't follow the
> standard style for KUnit tests [2].
> 
> [1]
> https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20220718/testrun/10865066/suite/kunit/tests/
> [2] https://docs.kernel.org/dev-tools/kunit/style.html

Thanks for the feedback, I wasn't aware of the style guidelines. See my reply to
David's message for the issues with the cpu_possible_mask tests.

Andrew, would you like me to resubmit the entire series, or can I just send a
new version of this patch?

Best,
Sander



  parent reply	other threads:[~2022-07-20 12:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-02 16:08 [PATCH v4 0/5] cpumask: Fix invalid uniprocessor assumptions Sander Vanheule
2022-07-02 16:08 ` [PATCH v4 1/5] x86/cacheinfo: move shared cache map definitions Sander Vanheule
2022-07-02 16:08 ` [PATCH v4 2/5] cpumask: Fix invalid uniprocessor mask assumption Sander Vanheule
2022-07-02 21:42   ` Yury Norov
2022-07-03 14:17     ` Sander Vanheule
2022-07-02 16:08 ` [PATCH v4 3/5] lib/test: Introduce cpumask KUnit test suite Sander Vanheule
2022-07-02 21:45   ` Yury Norov
2022-07-03  7:26     ` Sander Vanheule
2022-07-19 21:31   ` Maíra Canal
2022-07-20  5:24     ` David Gow
2022-07-20 12:43       ` Sander Vanheule
2022-07-20 12:47     ` Sander Vanheule [this message]
2022-07-02 16:08 ` [PATCH v4 4/5] cpumask: Add UP optimised for_each_*_cpu versions Sander Vanheule
2022-07-02 21:47   ` Yury Norov
2022-07-02 21:50     ` Yury Norov
2022-07-03  7:37       ` Sander Vanheule
2022-07-02 16:08 ` [PATCH v4 5/5] cpumask: Update cpumask_next_wrap() signature Sander Vanheule
2022-07-02 20:38 ` [PATCH v4 0/5] cpumask: Fix invalid uniprocessor assumptions Andrew Morton
2022-07-03  7:50   ` Sander Vanheule
2022-07-03 20:39     ` Andrew Morton
2022-07-10  6:51       ` Sander Vanheule
2022-07-11 20:22         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38c839001bbd10f58d12c64d78b5f310ee55f9aa.camel@svanheule.net \
    --to=sander@svanheule.net \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=brendanhiggins@google.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=davidgow@google.com \
    --cc=elver@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mairacanal@riseup.net \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=vschneid@redhat.com \
    --cc=x86@kernel.org \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®