From: John Johansen <john.johansen@canonical.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com,
apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next 1/2] apparmor: Modify mismatched function name
Date: Fri, 24 Jan 2025 14:03:58 -0800 [thread overview]
Message-ID: <38ca7459-4034-4171-a231-6c06af1391f2@canonical.com> (raw)
In-Reply-To: <20250121024444.88981-2-jiapeng.chong@linux.alibaba.com>
On 1/20/25 18:44, Jiapeng Chong wrote:
> No functional modification involved.
>
> security/apparmor/file.c:184: warning: expecting prototype for aa_lookup_fperms(). Prototype was for aa_lookup_condperms() instead.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=13605
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: John Johansen <john.johansen@canonical.com>
I have pulled this into my tree
> ---
> security/apparmor/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/file.c b/security/apparmor/file.c
> index 85f89814af1e..f113eedbc208 100644
> --- a/security/apparmor/file.c
> +++ b/security/apparmor/file.c
> @@ -169,7 +169,7 @@ static int path_name(const char *op, const struct cred *subj_cred,
>
> struct aa_perms default_perms = {};
> /**
> - * aa_lookup_fperms - convert dfa compressed perms to internal perms
> + * aa_lookup_condperms - convert dfa compressed perms to internal perms
> * @subj_uid: uid to use for subject owner test
> * @rules: the aa_policydb to lookup perms for (NOT NULL)
> * @state: state in dfa
next prev parent reply other threads:[~2025-01-24 22:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 2:44 [PATCH -next 2/2] " Jiapeng Chong
2025-01-21 2:44 ` [PATCH -next 1/2] " Jiapeng Chong
2025-01-24 22:03 ` John Johansen [this message]
2025-01-24 22:05 ` [PATCH -next 2/2] " John Johansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38ca7459-4034-4171-a231-6c06af1391f2@canonical.com \
--to=john.johansen@canonical.com \
--cc=abaci@linux.alibaba.com \
--cc=apparmor@lists.ubuntu.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®