mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Johansen <john.johansen@canonical.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com,
	apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next 2/2] apparmor: Modify mismatched function name
Date: Fri, 24 Jan 2025 14:05:32 -0800	[thread overview]
Message-ID: <97669024-c5df-46dc-93bb-3b54f179db1d@canonical.com> (raw)
In-Reply-To: <20250121024444.88981-1-jiapeng.chong@linux.alibaba.com>

On 1/20/25 18:44, Jiapeng Chong wrote:
> No functional modification involved.
> 
> security/apparmor/lib.c:93: warning: expecting prototype for aa_mask_to_str(). Prototype was for val_mask_to_str() instead.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=13606
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Acked-by: John Johansen <john.johansen@canonical.com>

I have pulled this into my tree

> ---
>   security/apparmor/lib.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/apparmor/lib.c b/security/apparmor/lib.c
> index dd5dcbe5daf7..325f26f39a63 100644
> --- a/security/apparmor/lib.c
> +++ b/security/apparmor/lib.c
> @@ -82,7 +82,7 @@ int aa_parse_debug_params(const char *str)
>   }
>   
>   /**
> - * aa_mask_to_str - convert a perm mask to its short string
> + * val_mask_to_str - convert a perm mask to its short string
>    * @str: character buffer to store string in (at least 10 characters)
>    * @str_size: size of the @str buffer
>    * @chrs: NUL-terminated character buffer of permission characters


      parent reply	other threads:[~2025-01-24 22:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21  2:44 Jiapeng Chong
2025-01-21  2:44 ` [PATCH -next 1/2] " Jiapeng Chong
2025-01-24 22:03   ` John Johansen
2025-01-24 22:05 ` John Johansen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97669024-c5df-46dc-93bb-3b54f179db1d@canonical.com \
    --to=john.johansen@canonical.com \
    --cc=abaci@linux.alibaba.com \
    --cc=apparmor@lists.ubuntu.com \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®