From: Stephen Warren <swarren@wwwdotorg.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver
Date: Mon, 25 Sep 2017 17:01:23 -0600 [thread overview]
Message-ID: <38daee0d-0595-a7e4-69bb-5a2ddbd832b5@wwwdotorg.org> (raw)
In-Reply-To: <5c8b83775b982e6ee851c127444a8e839f422ad0.1506377430.git.digetx@gmail.com>
On 09/25/2017 04:15 PM, Dmitry Osipenko wrote:
> Video decoder, found on NVIDIA Tegra20 SoC, supports a standard set of
> video formats like H.264 / MPEG-4 / WMV / VC1. Currently driver supports
> decoding of CAVLC H.264 only.
Note: I don't know anything much about video decoding on Tegra (just NV
desktop GPUs, and that was a while ago), but I had a couple small
comments on the DT binding:
> diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-vde.txt b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-vde.txt
> +NVIDIA Tegra Video Decoder Engine
> +
> +Required properties:
> +- compatible : "nvidia,tegra20-vde"
> +- reg : Must contain 2 register ranges: registers and IRAM area.
> +- reg-names : Must include the following entries:
> + - regs
> + - iram
I think the IRAM region needs more explanation: What is the region used
for and by what? Can it be moved, and if so does the move need to be
co-ordinated with any other piece of SW?
> +- clocks : Must contain one entry, for the module clock.
> + See ../clocks/clock-bindings.txt for details.
> +- resets : Must contain an entry for each entry in reset-names.
> + See ../reset/reset.txt for details.
> +- reset-names : Must include the following entries:
> + - vde
Let's require a clock-names property too.
next prev parent reply other threads:[~2017-09-25 23:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 22:15 [PATCH v1 0/2] " Dmitry Osipenko
2017-09-25 22:15 ` [PATCH v1 1/2] staging: Introduce " Dmitry Osipenko
2017-09-25 23:01 ` Stephen Warren [this message]
2017-09-25 23:45 ` Dmitry Osipenko
2017-09-26 5:11 ` Stephen Warren
2017-09-26 12:02 ` Dmitry Osipenko
2017-09-27 9:45 ` Dan Carpenter
2017-09-27 23:28 ` Dmitry Osipenko
2017-09-28 7:23 ` Dan Carpenter
2017-09-28 11:37 ` Dmitry Osipenko
2017-09-27 23:31 ` Dmitry Osipenko
2017-09-25 22:15 ` [PATCH v1 2/2] ARM: dts: tegra20: Add video decoder node Dmitry Osipenko
2017-09-26 6:54 ` [PATCH v1 0/2] NVIDIA Tegra20 video decoder driver Greg Kroah-Hartman
2017-09-26 12:32 ` Dmitry Osipenko
2017-09-26 21:35 ` Greg Kroah-Hartman
2017-09-26 22:17 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38daee0d-0595-a7e4-69bb-5a2ddbd832b5@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®