From: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
To: Hugues Fruchet <hugues.fruchet@foss.st.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Sylvain Petinot <sylvain.petinot@foss.st.com>
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Alain Volmat <alain.volmat@foss.st.com>
Subject: Re: [PATCH 3/3] media: st-mipid02: expose 1X16 serial pixel format
Date: Mon, 16 May 2022 12:12:48 +0200 [thread overview]
Message-ID: <39016a6e-6e8d-d263-da9d-47f3bb13988f@foss.st.com> (raw)
In-Reply-To: <20220516091934.263141-4-hugues.fruchet@foss.st.com>
On 16/05/2022 11:19, Hugues Fruchet wrote:
> Expose RGB & YUV 1X16 serial pixel format variants to comply
> with CSI-2 camera sensor pixel formats.
>
> Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> ---
> drivers/media/i2c/st-mipid02.c | 20 +++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/st-mipid02.c b/drivers/media/i2c/st-mipid02.c
> index fe884d81b08b..16cc547976dd 100644
> --- a/drivers/media/i2c/st-mipid02.c
> +++ b/drivers/media/i2c/st-mipid02.c
> @@ -62,7 +62,9 @@ static const u32 mipid02_supported_fmt_codes[] = {
> MEDIA_BUS_FMT_SGRBG10_1X10, MEDIA_BUS_FMT_SRGGB10_1X10,
> MEDIA_BUS_FMT_SBGGR12_1X12, MEDIA_BUS_FMT_SGBRG12_1X12,
> MEDIA_BUS_FMT_SGRBG12_1X12, MEDIA_BUS_FMT_SRGGB12_1X12,
> - MEDIA_BUS_FMT_UYVY8_1X16, MEDIA_BUS_FMT_BGR888_1X24,
> + MEDIA_BUS_FMT_YUYV8_1X16, MEDIA_BUS_FMT_YVYU8_1X16,
> + MEDIA_BUS_FMT_UYVY8_1X16, MEDIA_BUS_FMT_VYUY8_1X16,
> + MEDIA_BUS_FMT_RGB565_1X16, MEDIA_BUS_FMT_BGR888_1X24,
> MEDIA_BUS_FMT_RGB565_2X8_LE, MEDIA_BUS_FMT_RGB565_2X8_BE,
> MEDIA_BUS_FMT_YUYV8_2X8, MEDIA_BUS_FMT_YVYU8_2X8,
> MEDIA_BUS_FMT_UYVY8_2X8, MEDIA_BUS_FMT_VYUY8_2X8,
> @@ -132,7 +134,11 @@ static int bpp_from_code(__u32 code)
> case MEDIA_BUS_FMT_SGRBG12_1X12:
> case MEDIA_BUS_FMT_SRGGB12_1X12:
> return 12;
> + case MEDIA_BUS_FMT_YUYV8_1X16:
> + case MEDIA_BUS_FMT_YVYU8_1X16:
> case MEDIA_BUS_FMT_UYVY8_1X16:
> + case MEDIA_BUS_FMT_VYUY8_1X16:
> + case MEDIA_BUS_FMT_RGB565_1X16:
> case MEDIA_BUS_FMT_YUYV8_2X8:
> case MEDIA_BUS_FMT_YVYU8_2X8:
> case MEDIA_BUS_FMT_UYVY8_2X8:
> @@ -165,7 +171,10 @@ static u8 data_type_from_code(__u32 code)
> case MEDIA_BUS_FMT_SGRBG12_1X12:
> case MEDIA_BUS_FMT_SRGGB12_1X12:
> return 0x2c;
> + case MEDIA_BUS_FMT_YUYV8_1X16:
> + case MEDIA_BUS_FMT_YVYU8_1X16:
> case MEDIA_BUS_FMT_UYVY8_1X16:
> + case MEDIA_BUS_FMT_VYUY8_1X16:
> case MEDIA_BUS_FMT_YUYV8_2X8:
> case MEDIA_BUS_FMT_YVYU8_2X8:
> case MEDIA_BUS_FMT_UYVY8_2X8:
> @@ -173,6 +182,7 @@ static u8 data_type_from_code(__u32 code)
> return 0x1e;
> case MEDIA_BUS_FMT_BGR888_1X24:
> return 0x24;
> + case MEDIA_BUS_FMT_RGB565_1X16:
> case MEDIA_BUS_FMT_RGB565_2X8_LE:
> case MEDIA_BUS_FMT_RGB565_2X8_BE:
> return 0x22;
> @@ -207,8 +217,16 @@ static __u32 get_fmt_code(__u32 code)
>
> static __u32 serial_to_parallel_code(__u32 serial)
> {
> + if (serial == MEDIA_BUS_FMT_RGB565_1X16)
> + return MEDIA_BUS_FMT_RGB565_2X8_LE;
> + if (serial == MEDIA_BUS_FMT_YUYV8_1X16)
> + return MEDIA_BUS_FMT_YUYV8_2X8;
> + if (serial == MEDIA_BUS_FMT_YVYU8_1X16)
> + return MEDIA_BUS_FMT_YVYU8_2X8;
> if (serial == MEDIA_BUS_FMT_UYVY8_1X16)
> return MEDIA_BUS_FMT_UYVY8_2X8;
> + if (serial == MEDIA_BUS_FMT_VYUY8_1X16)
> + return MEDIA_BUS_FMT_VYUY8_2X8;
> if (serial == MEDIA_BUS_FMT_BGR888_1X24)
> return MEDIA_BUS_FMT_BGR888_3X8;
>
>
prev parent reply other threads:[~2022-05-16 10:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 9:19 [PATCH 0/3] MIPID02 pixel clk polarity & serial pixel formats Hugues Fruchet
2022-05-16 9:19 ` [PATCH 1/3] media: st-mipid02: add support of pixel clock polarity Hugues Fruchet
2022-05-16 10:12 ` Benjamin Mugnier
2022-05-16 9:19 ` [PATCH 2/3] media: st-mipid02: add support for YVYU and VYUY formats Hugues Fruchet
2022-05-16 10:12 ` Benjamin Mugnier
2022-05-16 9:19 ` [PATCH 3/3] media: st-mipid02: expose 1X16 serial pixel format Hugues Fruchet
2022-05-16 10:12 ` Benjamin Mugnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39016a6e-6e8d-d263-da9d-47f3bb13988f@foss.st.com \
--to=benjamin.mugnier@foss.st.com \
--cc=alain.volmat@foss.st.com \
--cc=hugues.fruchet@foss.st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sylvain.petinot@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®