[PATCH drm-misc-next] drm: verisilicon: remove the error message when getting IRQ fails

[PATCH drm-misc-next] drm: verisilicon: remove the error message when getting IRQ fails

[Icenowy Zheng]

The platform_get_irq() function has its own error report, so the error
message in the driver seems to be redundant.

Remove it.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202602242000.bQ0qN6AC-lkp@intel.com/
Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
---
 drivers/gpu/drm/verisilicon/vs_dc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/verisilicon/vs_dc.c b/drivers/gpu/drm/verisilicon/vs_dc.c
index 5f629d2d4beac..d2e216eaa3c9f 100644
--- a/drivers/gpu/drm/verisilicon/vs_dc.c
+++ b/drivers/gpu/drm/verisilicon/vs_dc.c
@@ -105,10 +105,8 @@ static int vs_dc_probe(struct platform_device *pdev)
 	}
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(dev, "can't get irq\n");
+	if (irq < 0)
 		return irq;
-	}
 
 	ret = reset_control_bulk_deassert(VSDC_RESET_COUNT, dc->rsts);
 	if (ret) {
-- 
2.52.0

Re: [PATCH drm-misc-next] drm: verisilicon: remove the error message when getting IRQ fails

[Thomas Zimmermann]

Am 05.03.26 um 09:22 schrieb Icenowy Zheng:
> The platform_get_irq() function has its own error report, so the error
> message in the driver seems to be redundant.
>
> Remove it.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202602242000.bQ0qN6AC-lkp@intel.com/
> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   drivers/gpu/drm/verisilicon/vs_dc.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/verisilicon/vs_dc.c b/drivers/gpu/drm/verisilicon/vs_dc.c
> index 5f629d2d4beac..d2e216eaa3c9f 100644
> --- a/drivers/gpu/drm/verisilicon/vs_dc.c
> +++ b/drivers/gpu/drm/verisilicon/vs_dc.c
> @@ -105,10 +105,8 @@ static int vs_dc_probe(struct platform_device *pdev)
>   	}
>   
>   	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(dev, "can't get irq\n");
> +	if (irq < 0)
>   		return irq;
> -	}
>   
>   	ret = reset_control_bulk_deassert(VSDC_RESET_COUNT, dc->rsts);
>   	if (ret) {

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)