mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Christophe Leroy <chleroy@kernel.org>,
	Venkat Rao Bagalkote <venkat88@linux.ibm.com>,
	Shrikanth Hegde <sshegde@linux.ibm.com>,
	Marco Elver <elver@google.com>,
	linux-kernel@vger.kernel.org,
	"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Subject: [RFC 09/12] powerpc/pseries: Disable context analysis for the CMM hotplug notifier
Date: Sun, 27 Sep 2026 20:03:50 +0530	[thread overview]
Message-ID: <39297f9916c1eb80f4835ac33c7200fd7b5ddaa2.1790517984.git.ritesh.list@gmail.com> (raw)
In-Reply-To: <cover.1790517984.git.ritesh.list@gmail.com>

Clang's context analysis reports:
  cmm.c: error: mutex 'hotplug_mutex' is still held at the end of function [-Werror,-Wthread-safety-analysis]
  cmm.c: error: releasing mutex 'hotplug_mutex' that was not held [-Werror,-Wthread-safety-analysis]

cmm_memory_cb() takes hotplug_mutex on MEM_GOING_OFFLINE and drops it
on a later MEM_OFFLINE or MEM_CANCEL_OFFLINE call.

Add __context_unsafe() annotation for cmm_memory_cb() callback to avoid
the reported build error in order to enable Clang context analysis.

Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
---
 arch/powerpc/platforms/pseries/cmm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/pseries/cmm.c b/arch/powerpc/platforms/pseries/cmm.c
index 38e22125b96f..159efe734785 100644
--- a/arch/powerpc/platforms/pseries/cmm.c
+++ b/arch/powerpc/platforms/pseries/cmm.c
@@ -470,6 +470,7 @@ static struct notifier_block cmm_reboot_nb = {
  **/
 static int cmm_memory_cb(struct notifier_block *self,
 			unsigned long action, void *arg)
+		__context_unsafe(/* Conditional locking */)
 {
 	switch (action) {
 	case MEM_GOING_OFFLINE:
-- 
2.39.5


  parent reply	other threads:[~2026-09-27 14:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-27 14:33 [RFC 00/12] powerpc/pseries,powernv: Enable clang context analysis Ritesh Harjani (IBM)
2026-09-27 14:33 ` [RFC 01/12] powerpc/pseries: Drop inline from hugepage invalidate Ritesh Harjani (IBM)
2026-09-27 14:33 ` [RFC 02/12] powerpc/pseries: Rework hugepage invalidate to remove conditional locking Ritesh Harjani (IBM)
2026-09-27 14:33 ` [RFC 03/12] powerpc/pseries: Rework hash flush " Ritesh Harjani (IBM)
2026-09-27 14:33 ` [RFC 04/12] powerpc/pseries: Add context annotations for the DTL worker lock Ritesh Harjani (IBM)
2026-09-27 14:33 ` [RFC 05/12] powerpc/pseries: Annotate the VPD sequence lock context Ritesh Harjani (IBM)
2026-09-27 14:33 ` [RFC 06/12] powerpc/pseries: Annotate the RTAS indices " Ritesh Harjani (IBM)
2026-09-27 14:33 ` [RFC 07/12] powerpc/pseries: Annotate the RTAS physical-attestation " Ritesh Harjani (IBM)
2026-09-27 14:33 ` [RFC 08/12] powerpc/pseries: Annotate the DTL debugfs read " Ritesh Harjani (IBM)
2026-09-29  2:04   ` Ritesh Harjani
2026-09-27 14:33 ` Ritesh Harjani (IBM) [this message]
2026-09-27 14:33 ` [RFC 10/12] powerpc/pseries: Enable context analysis Ritesh Harjani (IBM)
2026-09-27 14:33 ` [RFC 11/12] powerpc/powernv: Rework OPAL console write to remove conditional locking Ritesh Harjani (IBM)
2026-09-27 14:33 ` [RFC 12/12] powerpc/powernv: Enable context analysis Ritesh Harjani (IBM)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39297f9916c1eb80f4835ac33c7200fd7b5ddaa2.1790517984.git.ritesh.list@gmail.com \
    --to=ritesh.list@gmail.com \
    --cc=chleroy@kernel.org \
    --cc=elver@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=sshegde@linux.ibm.com \
    --cc=venkat88@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®