From: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Christophe Leroy <chleroy@kernel.org>,
Venkat Rao Bagalkote <venkat88@linux.ibm.com>,
Shrikanth Hegde <sshegde@linux.ibm.com>,
Marco Elver <elver@google.com>,
linux-kernel@vger.kernel.org,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Subject: [RFC 05/12] powerpc/pseries: Annotate the VPD sequence lock context
Date: Sun, 27 Sep 2026 20:03:46 +0530 [thread overview]
Message-ID: <d8908c2991181b75c20dfd8e23a58e7779bc7dee.1790517984.git.ritesh.list@gmail.com> (raw)
In-Reply-To: <cover.1790517984.git.ritesh.list@gmail.com>
Clang's context analysis reports:
papr-vpd.c:151:1: error: mutex 'rtas_ibm_get_vpd_lock' is still held at the end of function [-Werror,-Wthread-safety-analysis]
papr-vpd.c:165:2: error: releasing mutex 'rtas_ibm_get_vpd_lock' that was not held [-Werror,-Wthread-safety-analysis]
Add the necessary annotations to in vpd_sequence_{begin|end}(),
to fix these errors for enabling Clang context analysis.
Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
---
arch/powerpc/platforms/pseries/papr-vpd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/powerpc/platforms/pseries/papr-vpd.c b/arch/powerpc/platforms/pseries/papr-vpd.c
index f38c188fc4a1..8d210454cff1 100644
--- a/arch/powerpc/platforms/pseries/papr-vpd.c
+++ b/arch/powerpc/platforms/pseries/papr-vpd.c
@@ -123,8 +123,10 @@ static int rtas_ibm_get_vpd(struct rtas_ibm_get_vpd_params *params)
* @seq: vpd call parameters from sequence struct
*
* Context: May sleep.
+ * Returns with rtas_ibm_get_vpd_lock held. vpd_sequence_end() releases it.
*/
static void vpd_sequence_begin(struct papr_rtas_sequence *seq)
+ __acquires(&rtas_ibm_get_vpd_lock)
{
struct rtas_ibm_get_vpd_params *vpd_params;
/*
@@ -157,6 +159,7 @@ static void vpd_sequence_begin(struct papr_rtas_sequence *seq)
* Releases resources obtained by vpd_sequence_begin().
*/
static void vpd_sequence_end(struct papr_rtas_sequence *seq)
+ __releases(&rtas_ibm_get_vpd_lock)
{
struct rtas_ibm_get_vpd_params *vpd_params;
--
2.39.5
next prev parent reply other threads:[~2026-09-27 14:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 14:33 [RFC 00/12] powerpc/pseries,powernv: Enable clang context analysis Ritesh Harjani (IBM)
2026-09-27 14:33 ` [RFC 01/12] powerpc/pseries: Drop inline from hugepage invalidate Ritesh Harjani (IBM)
2026-09-27 14:33 ` [RFC 02/12] powerpc/pseries: Rework hugepage invalidate to remove conditional locking Ritesh Harjani (IBM)
2026-09-27 14:33 ` [RFC 03/12] powerpc/pseries: Rework hash flush " Ritesh Harjani (IBM)
2026-09-27 14:33 ` [RFC 04/12] powerpc/pseries: Add context annotations for the DTL worker lock Ritesh Harjani (IBM)
2026-09-27 14:33 ` Ritesh Harjani (IBM) [this message]
2026-09-27 14:33 ` [RFC 06/12] powerpc/pseries: Annotate the RTAS indices sequence lock context Ritesh Harjani (IBM)
2026-09-27 14:33 ` [RFC 07/12] powerpc/pseries: Annotate the RTAS physical-attestation " Ritesh Harjani (IBM)
2026-09-27 14:33 ` [RFC 08/12] powerpc/pseries: Annotate the DTL debugfs read " Ritesh Harjani (IBM)
2026-09-27 14:33 ` [RFC 09/12] powerpc/pseries: Disable context analysis for the CMM hotplug notifier Ritesh Harjani (IBM)
2026-09-27 14:33 ` [RFC 10/12] powerpc/pseries: Enable context analysis Ritesh Harjani (IBM)
2026-09-27 14:33 ` [RFC 11/12] powerpc/powernv: Rework OPAL console write to remove conditional locking Ritesh Harjani (IBM)
2026-09-27 14:33 ` [RFC 12/12] powerpc/powernv: Enable context analysis Ritesh Harjani (IBM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8908c2991181b75c20dfd8e23a58e7779bc7dee.1790517984.git.ritesh.list@gmail.com \
--to=ritesh.list@gmail.com \
--cc=chleroy@kernel.org \
--cc=elver@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=sshegde@linux.ibm.com \
--cc=venkat88@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®