mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	POTIN LAI <potin.lai@quantatw.com>,
	Jean Delvare <jdelvare@suse.com>,
	Rob Herring <robh+dt@kernel.org>
Cc: Patrick Williams <patrick@stwcx.xyz>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings: hwmon: Add sample averaging properties for ADM1275
Date: Tue, 1 Mar 2022 08:47:11 -0800	[thread overview]
Message-ID: <39415d57-ec14-aab8-20fd-92d2a810f3fd@roeck-us.net> (raw)
In-Reply-To: <bf1fa181-d2a7-eab9-4045-cf53ae3ce2f2@kernel.org>

On 3/1/22 05:21, Krzysztof Kozlowski wrote:
> On 01/03/2022 13:42, POTIN LAI wrote:
>>
>> Krzysztof Kozlowski 於 1/03/2022 7:16 pm 寫道:
>>> On 01/03/2022 11:39, Potin Lai wrote:
>>>> Add documentation of new properties for sample averaging in PMON_CONFIG
>>>> register.
>>>>
>>>> New properties:
>>>> - adi,volt-curr-sample-average
>>>> - adi,power-sample-average
>>>> - adi,power-sample-average-enable
>>>>
>>>> Signed-off-by: Potin Lai <potin.lai@quantatw.com>
>>>> ---
>>>>   .../bindings/hwmon/adi,adm1275.yaml           | 44 +++++++++++++++++++
>>>>   1 file changed, 44 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
>>>> index 223393d7cafd..1b612dc06992 100644
>>>> --- a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
>>>> +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
>>>> @@ -37,6 +37,47 @@ properties:
>>>>       description:
>>>>         Shunt resistor value in micro-Ohm.
>>>>   
>>>> +  adi,volt-curr-sample-average:
>>>> +    description: |
>>>> +      Number of samples to be used to report voltage and current values.
>>>> +      If the configured value is not a power of 2, sample averaging number
>>>> +      will be configured with smaller and closest power of 2.
>>>> +
>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>> +    enum: [1, 2, 4, 8, 16, 32, 64, 128]
>>>> +    default: 1
>>>> +
>>>> +  adi,power-sample-average:
>>>> +    description: |
>>>> +      Number of samples to be used to report power values.
>>>> +      If the configured value is not a power of 2, sample averaging number
>>>> +      will be configured with smaller and closest power of 2.
>>>> +
>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>> +    enum: [1, 2, 4, 8, 16, 32, 64, 128]
>>>> +    default: 1
>>>> +
>>>> +  adi,power-sample-average-enable:
>>>> +    description: Enable sample averaging for power reading.
>>>> +    type: boolean
>>> Why do you need this property? Voltage/current sampling is enabled in
>>> your driver with presence of adi,volt-curr-sample-average. Why power
>>> sampling is different?
>> For "adi,power-sample-average", adm1075, adm1275 & adm127 don't have config reg for power sample average, so I add boolean type property to enable it
>> But for "adi,power-sample-average-enable", all chips have ability of configuring, so it doesn't need a property to enable or disable.
> 
> So the reason to add separate property is that this feature can be
> disabled. Since your driver does not disable it, it seems it is a
> default state to have it disabled and you have to enable it, right?
> Where is the enable code? I see you only write the sample averaging
> value with adm1275_write_pmon_config(). There is no enable...
> 
> But wait, the power averaging is being disabled by writing 0 to
> register, which is not allowed by bindings. How one can disable it?
> 

Valid register values are 0..7, matching dt property values of
BIT(x) or 1 .. 128. Setting the property value to 1 (= 1 sample)
is equivalent to disabling sampling.

> I don't see any usage of "adi,power-sample-average-enable", neither in
> driver nor in hardware. I also do not see the need for it, the purpose.
> 
> Then second part, you added default value of 1 to
> adi,volt-curr-sample-average and adi,power-sample-average. If the
> property is missing, then the default of 1 is applied, right? But
> datasheet says that default is 128!
> 
> The bindings neither match hardware nor driver. They look entirely
> independent. This is wrong. They should instead be strongly related to
> the hardware, describe the hardware. Then the driver should implement
> proper logic for it.
> 

Agreed.

Guenter

      reply	other threads:[~2022-03-01 16:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 10:38 [PATCH v4 0/2] hwmon: (adm1275) Add sample averaging binding support Potin Lai
2022-03-01 10:38 ` [PATCH v4 1/2] hwmon: (adm1275) Allow setting sample averaging Potin Lai
2022-03-01 10:39 ` [PATCH v4 2/2] dt-bindings: hwmon: Add sample averaging properties for ADM1275 Potin Lai
2022-03-01 11:16   ` Krzysztof Kozlowski
2022-03-01 12:42     ` POTIN LAI
2022-03-01 13:21       ` Krzysztof Kozlowski
2022-03-01 16:47         ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39415d57-ec14-aab8-20fd-92d2a810f3fd@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=krzk@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrick@stwcx.xyz \
    --cc=potin.lai@quantatw.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®