mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: POTIN LAI <potin.lai@quantatw.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Rob Herring <robh+dt@kernel.org>
Cc: Patrick Williams <patrick@stwcx.xyz>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings: hwmon: Add sample averaging properties for ADM1275
Date: Tue, 1 Mar 2022 20:42:39 +0800	[thread overview]
Message-ID: <9bb56622-2859-1059-6f14-2242ab6a2427@quantatw.com> (raw)
In-Reply-To: <da4ac970-9e7d-c9cb-eea3-e5ec8a1eef00@kernel.org>


Krzysztof Kozlowski 於 1/03/2022 7:16 pm 寫道:
> On 01/03/2022 11:39, Potin Lai wrote:
>> Add documentation of new properties for sample averaging in PMON_CONFIG
>> register.
>>
>> New properties:
>> - adi,volt-curr-sample-average
>> - adi,power-sample-average
>> - adi,power-sample-average-enable
>>
>> Signed-off-by: Potin Lai <potin.lai@quantatw.com>
>> ---
>>  .../bindings/hwmon/adi,adm1275.yaml           | 44 +++++++++++++++++++
>>  1 file changed, 44 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
>> index 223393d7cafd..1b612dc06992 100644
>> --- a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
>> +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
>> @@ -37,6 +37,47 @@ properties:
>>      description:
>>        Shunt resistor value in micro-Ohm.
>>  
>> +  adi,volt-curr-sample-average:
>> +    description: |
>> +      Number of samples to be used to report voltage and current values.
>> +      If the configured value is not a power of 2, sample averaging number
>> +      will be configured with smaller and closest power of 2.
>> +
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    enum: [1, 2, 4, 8, 16, 32, 64, 128]
>> +    default: 1
>> +
>> +  adi,power-sample-average:
>> +    description: |
>> +      Number of samples to be used to report power values.
>> +      If the configured value is not a power of 2, sample averaging number
>> +      will be configured with smaller and closest power of 2.
>> +
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    enum: [1, 2, 4, 8, 16, 32, 64, 128]
>> +    default: 1
>> +
>> +  adi,power-sample-average-enable:
>> +    description: Enable sample averaging for power reading.
>> +    type: boolean
> Why do you need this property? Voltage/current sampling is enabled in
> your driver with presence of adi,volt-curr-sample-average. Why power
> sampling is different?
For "adi,power-sample-average", adm1075, adm1275 & adm127 don't have config reg for power sample average, so I add boolean type property to enable it
But for "adi,power-sample-average-enable", all chips have ability of configuring, so it doesn't need a property to enable or disable.


Does example means that I can set any type (not just boolean?) of property to false if not allowed?
Could I write as below?

allOf:
  - if:
      properties:
        compatible:
          contains:
            enum:
              - chips_not_support
    then:
      properties:
        adi,power-sample-average: false

Sorry, I am not quite understand the example of set property not allowed, if I still get it wrong, please advise more detailed, thank you.


Potin
>
> Best regards,
> Krzysztof

  reply	other threads:[~2022-03-01 12:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 10:38 [PATCH v4 0/2] hwmon: (adm1275) Add sample averaging binding support Potin Lai
2022-03-01 10:38 ` [PATCH v4 1/2] hwmon: (adm1275) Allow setting sample averaging Potin Lai
2022-03-01 10:39 ` [PATCH v4 2/2] dt-bindings: hwmon: Add sample averaging properties for ADM1275 Potin Lai
2022-03-01 11:16   ` Krzysztof Kozlowski
2022-03-01 12:42     ` POTIN LAI [this message]
2022-03-01 13:21       ` Krzysztof Kozlowski
2022-03-01 16:47         ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bb56622-2859-1059-6f14-2242ab6a2427@quantatw.com \
    --to=potin.lai@quantatw.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=krzk@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=patrick@stwcx.xyz \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®