* [GIT PULL] SCSI fixes for 6.13-rc2
@ 2024-12-14 23:08 James Bottomley
2024-12-15 0:02 ` Linus Torvalds
2024-12-15 0:54 ` pr-tracker-bot
0 siblings, 2 replies; 3+ messages in thread
From: James Bottomley @ 2024-12-14 23:08 UTC (permalink / raw)
To: Andrew Morton, Linus Torvalds; +Cc: linux-scsi, linux-kernel
Simple one-line fix in the ufs driver.
The patch is available here:
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes
The short changelog is:
liuderong (1):
scsi: ufs: core: Update compl_time_stamp_local_clock after completing a cqe
And the diffstat:
drivers/ufs/core/ufshcd.c | 1 +
1 file changed, 1 insertion(+)
With full diff below.
Regards,
James
---
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index b7ec5797d5ba..8a01e4393159 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -5556,6 +5556,7 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag,
lrbp = &hba->lrb[task_tag];
lrbp->compl_time_stamp = ktime_get();
+ lrbp->compl_time_stamp_local_clock = local_clock();
cmd = lrbp->cmd;
if (cmd) {
if (unlikely(ufshcd_should_inform_monitor(hba, lrbp)))
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GIT PULL] SCSI fixes for 6.13-rc2
2024-12-14 23:08 [GIT PULL] SCSI fixes for 6.13-rc2 James Bottomley
@ 2024-12-15 0:02 ` Linus Torvalds
2024-12-15 0:54 ` pr-tracker-bot
1 sibling, 0 replies; 3+ messages in thread
From: Linus Torvalds @ 2024-12-15 0:02 UTC (permalink / raw)
To: James Bottomley; +Cc: Andrew Morton, linux-scsi, linux-kernel
On Sat, 14 Dec 2024 at 15:08, James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
>
> scsi: ufs: core: Update compl_time_stamp_local_clock after completing a cqe
Why does that ufs driver have that pointless "local_clock" version,
when it also does a real ktime?
It's documented to be just for debugging.
Then the "ktime" version is documented to be for statistics.
What makes this all make sense? Two different clocks, for two
different non-essential uses? And that duplication literally causes
bugs because clearly people get confused.
This particular bug has been around for almost two years, so equally
clearly these timestamps really *really* aren't that important.
Can we just agree that it's silly *and* confusing to maintain two
different completely unimportant timestamps in parallel, and just get
rid of at least one of them?
Linus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GIT PULL] SCSI fixes for 6.13-rc2
2024-12-14 23:08 [GIT PULL] SCSI fixes for 6.13-rc2 James Bottomley
2024-12-15 0:02 ` Linus Torvalds
@ 2024-12-15 0:54 ` pr-tracker-bot
1 sibling, 0 replies; 3+ messages in thread
From: pr-tracker-bot @ 2024-12-15 0:54 UTC (permalink / raw)
To: James Bottomley; +Cc: Andrew Morton, Linus Torvalds, linux-scsi, linux-kernel
The pull request you sent on Sat, 14 Dec 2024 18:08:14 -0500:
> git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/2d8308bf5b67dff50262d8a9260a50113b3628c6
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-15 0:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-14 23:08 [GIT PULL] SCSI fixes for 6.13-rc2 James Bottomley
2024-12-15 0:02 ` Linus Torvalds
2024-12-15 0:54 ` pr-tracker-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®