* [PATCH] ide: don't call memcpy with the same source and destination
@ 2017-04-14 18:35 Mikulas Patocka
[not found] ` <CGME20170418105834epcas1p1b000622da41db1214d1a9a1b888f7896@epcas1p1.samsung.com>
2017-05-08 21:37 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Mikulas Patocka @ 2017-04-14 18:35 UTC (permalink / raw)
To: David S. Miller
Cc: linux-ide, linux-kernel, James E.J. Bottomley, Helge Deller,
John David Anglin, linux-parisc
The parisc architecture recently reimplemented the memcpy function and
their reimplementation crashed when source and destination overlapped.
The crash happened in the function ide_complete_cmd where memcpy is called
with the same source and destination pointer. According to the C
specification, memcpy behavior is undefined if the source and destination
range overlaps. This patches fixes the undefined behavior.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
---
drivers/ide/ide-io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-4.11-rc6/drivers/ide/ide-io.c
===================================================================
--- linux-4.11-rc6.orig/drivers/ide/ide-io.c
+++ linux-4.11-rc6/drivers/ide/ide-io.c
@@ -107,7 +107,7 @@ void ide_complete_cmd(ide_drive_t *drive
if (cmd->tf_flags & IDE_TFLAG_DYN)
kfree(orig_cmd);
- else
+ else if (cmd != orig_cmd)
memcpy(orig_cmd, cmd, sizeof(*cmd));
}
}
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <CGME20170418105834epcas1p1b000622da41db1214d1a9a1b888f7896@epcas1p1.samsung.com>]
* Re: [PATCH] ide: don't call memcpy with the same source and destination
[not found] ` <CGME20170418105834epcas1p1b000622da41db1214d1a9a1b888f7896@epcas1p1.samsung.com>
@ 2017-04-18 10:58 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-04-18 10:58 UTC (permalink / raw)
To: Mikulas Patocka
Cc: David S. Miller, linux-ide, linux-kernel, James E.J. Bottomley,
Helge Deller, John David Anglin, linux-parisc
On Friday, April 14, 2017 02:35:33 PM Mikulas Patocka wrote:
> The parisc architecture recently reimplemented the memcpy function and
> their reimplementation crashed when source and destination overlapped.
>
> The crash happened in the function ide_complete_cmd where memcpy is called
> with the same source and destination pointer. According to the C
> specification, memcpy behavior is undefined if the source and destination
> range overlaps. This patches fixes the undefined behavior.
>
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ide: don't call memcpy with the same source and destination
2017-04-14 18:35 [PATCH] ide: don't call memcpy with the same source and destination Mikulas Patocka
[not found] ` <CGME20170418105834epcas1p1b000622da41db1214d1a9a1b888f7896@epcas1p1.samsung.com>
@ 2017-05-08 21:37 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-05-08 21:37 UTC (permalink / raw)
To: mpatocka; +Cc: linux-ide, linux-kernel, jejb, deller, dave.anglin, linux-parisc
From: Mikulas Patocka <mpatocka@redhat.com>
Date: Fri, 14 Apr 2017 14:35:33 -0400 (EDT)
> The parisc architecture recently reimplemented the memcpy function and
> their reimplementation crashed when source and destination overlapped.
>
> The crash happened in the function ide_complete_cmd where memcpy is called
> with the same source and destination pointer. According to the C
> specification, memcpy behavior is undefined if the source and destination
> range overlaps. This patches fixes the undefined behavior.
>
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-08 21:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-14 18:35 [PATCH] ide: don't call memcpy with the same source and destination Mikulas Patocka
[not found] ` <CGME20170418105834epcas1p1b000622da41db1214d1a9a1b888f7896@epcas1p1.samsung.com>
2017-04-18 10:58 ` Bartlomiej Zolnierkiewicz
2017-05-08 21:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome