* [PATCH 1/1 linux-next] ACPI: remove unnecessary sizeof(u8)
@ 2014-11-16 9:57 Fabian Frederick
2014-11-18 23:28 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-11-16 9:57 UTC (permalink / raw)
To: linux-kernel; +Cc: Fabian Frederick, Rafael J. Wysocki, Len Brown, linux-acpi
sizeof(u8) is always 1.
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/acpi/utils.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
index 371ac12..dd8ff63 100644
--- a/drivers/acpi/utils.c
+++ b/drivers/acpi/utils.c
@@ -136,8 +136,7 @@ acpi_extract_package(union acpi_object *package,
break;
case 'B':
size_required +=
- sizeof(u8 *) +
- (element->buffer.length * sizeof(u8));
+ sizeof(u8 *) + element->buffer.length;
tail_offset += sizeof(u8 *);
break;
default:
@@ -255,7 +254,7 @@ acpi_extract_package(union acpi_object *package,
memcpy(tail, element->buffer.pointer,
element->buffer.length);
head += sizeof(u8 *);
- tail += element->buffer.length * sizeof(u8);
+ tail += element->buffer.length;
break;
default:
/* Should never get here */
--
1.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1 linux-next] ACPI: remove unnecessary sizeof(u8)
2014-11-16 9:57 [PATCH 1/1 linux-next] ACPI: remove unnecessary sizeof(u8) Fabian Frederick
@ 2014-11-18 23:28 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2014-11-18 23:28 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, Len Brown, linux-acpi
On Sunday, November 16, 2014 10:57:00 AM Fabian Frederick wrote:
> sizeof(u8) is always 1.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Queued up for 3.19-rc1, thanks!
> ---
> drivers/acpi/utils.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
> index 371ac12..dd8ff63 100644
> --- a/drivers/acpi/utils.c
> +++ b/drivers/acpi/utils.c
> @@ -136,8 +136,7 @@ acpi_extract_package(union acpi_object *package,
> break;
> case 'B':
> size_required +=
> - sizeof(u8 *) +
> - (element->buffer.length * sizeof(u8));
> + sizeof(u8 *) + element->buffer.length;
> tail_offset += sizeof(u8 *);
> break;
> default:
> @@ -255,7 +254,7 @@ acpi_extract_package(union acpi_object *package,
> memcpy(tail, element->buffer.pointer,
> element->buffer.length);
> head += sizeof(u8 *);
> - tail += element->buffer.length * sizeof(u8);
> + tail += element->buffer.length;
> break;
> default:
> /* Should never get here */
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-18 23:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-16 9:57 [PATCH 1/1 linux-next] ACPI: remove unnecessary sizeof(u8) Fabian Frederick
2014-11-18 23:28 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®