mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] pinctrl: qcom: qcs615: Add missing dual edge GPIO IRQ errata flag
@ 2026-02-07  7:33 Maulik Shah
  2026-02-07  9:09 ` Dmitry Baryshkov
  0 siblings, 1 reply; 3+ messages in thread
From: Maulik Shah @ 2026-02-07  7:33 UTC (permalink / raw)
  To: Bjorn Andersson, Linus Walleij, Lijuan Gao
  Cc: linux-arm-msm, linux-gpio, linux-kernel, Maulik Shah

Configuring GPIO IRQ as dual edge breaks as the wakeirq_dual_edge_errata is
not set. Add missing wakeirq_dual_edge_errata flag.

Fixes: b698f36a9d40 ("pinctrl: qcom: add the tlmm driver for QCS615 platform")
Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
---
 drivers/pinctrl/qcom/pinctrl-qcs615.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/qcom/pinctrl-qcs615.c b/drivers/pinctrl/qcom/pinctrl-qcs615.c
index 4dfa820d4e77ce8157a3503ee8ec6e426b54e030..f1c827ddbfbfa59d03ddea560eca36ffa997aa8d 100644
--- a/drivers/pinctrl/qcom/pinctrl-qcs615.c
+++ b/drivers/pinctrl/qcom/pinctrl-qcs615.c
@@ -1067,6 +1067,7 @@ static const struct msm_pinctrl_soc_data qcs615_tlmm = {
 	.ntiles = ARRAY_SIZE(qcs615_tiles),
 	.wakeirq_map = qcs615_pdc_map,
 	.nwakeirq_map = ARRAY_SIZE(qcs615_pdc_map),
+	.wakeirq_dual_edge_errata = true,
 };
 
 static const struct of_device_id qcs615_tlmm_of_match[] = {

---
base-commit: 9845cf73f7db6094c0d8419d6adb848028f4a921
change-id: 20260207-qcs615_gpio-7b76c94f6921

Best regards,
-- 
Maulik Shah <maulik.shah@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: qcom: qcs615: Add missing dual edge GPIO IRQ errata flag
  2026-02-07  7:33 [PATCH] pinctrl: qcom: qcs615: Add missing dual edge GPIO IRQ errata flag Maulik Shah
@ 2026-02-07  9:09 ` Dmitry Baryshkov
  2026-02-09  3:38   ` Maulik Shah (mkshah)
  0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Baryshkov @ 2026-02-07  9:09 UTC (permalink / raw)
  To: Maulik Shah
  Cc: Bjorn Andersson, Linus Walleij, Lijuan Gao, linux-arm-msm,
	linux-gpio, linux-kernel

On Sat, Feb 07, 2026 at 01:03:30PM +0530, Maulik Shah wrote:
> Configuring GPIO IRQ as dual edge breaks as the wakeirq_dual_edge_errata is
> not set. Add missing wakeirq_dual_edge_errata flag.

It breaks because HW doesn't support it, not because the flag is not
set.

> 
> Fixes: b698f36a9d40 ("pinctrl: qcom: add the tlmm driver for QCS615 platform")
> Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
> ---
>  drivers/pinctrl/qcom/pinctrl-qcs615.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-qcs615.c b/drivers/pinctrl/qcom/pinctrl-qcs615.c
> index 4dfa820d4e77ce8157a3503ee8ec6e426b54e030..f1c827ddbfbfa59d03ddea560eca36ffa997aa8d 100644
> --- a/drivers/pinctrl/qcom/pinctrl-qcs615.c
> +++ b/drivers/pinctrl/qcom/pinctrl-qcs615.c
> @@ -1067,6 +1067,7 @@ static const struct msm_pinctrl_soc_data qcs615_tlmm = {
>  	.ntiles = ARRAY_SIZE(qcs615_tiles),
>  	.wakeirq_map = qcs615_pdc_map,
>  	.nwakeirq_map = ARRAY_SIZE(qcs615_pdc_map),
> +	.wakeirq_dual_edge_errata = true,
>  };
>  
>  static const struct of_device_id qcs615_tlmm_of_match[] = {
> 
> ---
> base-commit: 9845cf73f7db6094c0d8419d6adb848028f4a921
> change-id: 20260207-qcs615_gpio-7b76c94f6921
> 
> Best regards,
> -- 
> Maulik Shah <maulik.shah@oss.qualcomm.com>
> 

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: qcom: qcs615: Add missing dual edge GPIO IRQ errata flag
  2026-02-07  9:09 ` Dmitry Baryshkov
@ 2026-02-09  3:38   ` Maulik Shah (mkshah)
  0 siblings, 0 replies; 3+ messages in thread
From: Maulik Shah (mkshah) @ 2026-02-09  3:38 UTC (permalink / raw)
  To: Dmitry Baryshkov
  Cc: Bjorn Andersson, Linus Walleij, Lijuan Gao, linux-arm-msm,
	linux-gpio, linux-kernel



On 2/7/2026 2:39 PM, Dmitry Baryshkov wrote:
> On Sat, Feb 07, 2026 at 01:03:30PM +0530, Maulik Shah wrote:
>> Configuring GPIO IRQ as dual edge breaks as the wakeirq_dual_edge_errata is
>> not set. Add missing wakeirq_dual_edge_errata flag.
> 
> It breaks because HW doesn't support it, not because the flag is not
> set.
> 

Ack. I will update v2 to mention older HW did not support dual edge.

Thanks,
Maulik

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-02-09  3:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-07  7:33 [PATCH] pinctrl: qcom: qcs615: Add missing dual edge GPIO IRQ errata flag Maulik Shah
2026-02-07  9:09 ` Dmitry Baryshkov
2026-02-09  3:38   ` Maulik Shah (mkshah)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®