From: Dan Carpenter <dan.carpenter@linaro.org>
To: Hidenori Kobayashi <hidenorik@chromium.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Bingbu Cao <bingbu.cao@intel.com>,
Tianshu Qiu <tian.shu.qiu@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Yong Zhi <yong.zhi@intel.com>,
stable@vger.kernel.org,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] media: staging: ipu3-imgu: Set fields before media_entity_pads_init()
Date: Tue, 9 Jan 2024 11:12:59 +0300 [thread overview]
Message-ID: <398e06b3-351e-4a1d-b3e4-9c02893ccd83@moroto.mountain> (raw)
In-Reply-To: <20240109080910.2859780-1-hidenorik@chromium.org>
On Tue, Jan 09, 2024 at 05:09:09PM +0900, Hidenori Kobayashi wrote:
> The imgu driver fails to probe with the following message because it
> does not set the pad's flags before calling media_entity_pads_init().
>
> [ 14.596315] ipu3-imgu 0000:00:05.0: failed initialize subdev media entity (-22)
> [ 14.596322] ipu3-imgu 0000:00:05.0: failed to register subdev0 ret (-22)
> [ 14.596327] ipu3-imgu 0000:00:05.0: failed to register pipes (-22)
> [ 14.596331] ipu3-imgu 0000:00:05.0: failed to create V4L2 devices (-22)
>
> Fix the initialization order so that the driver probe succeeds. The ops
> initialization is also moved together for readability.
>
> Fixes: a0ca1627b450 ("media: staging/intel-ipu3: Add v4l2 driver based on media framework")
> Cc: <stable@vger.kernel.org> # 6.7
> Cc: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Hidenori Kobayashi <hidenorik@chromium.org>
> ---
Thanks so much!
regards,
dan carpenter
prev parent reply other threads:[~2024-01-09 8:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 8:09 Hidenori Kobayashi
2024-01-09 8:12 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=398e06b3-351e-4a1d-b3e4-9c02893ccd83@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=bingbu.cao@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hidenorik@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab+samsung@kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=tian.shu.qiu@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®