From: Mario Limonciello <mario.limonciello@amd.com>
To: Munique Feitoza <muniquefeitoz4@gmail.com>,
Linus Walleij <linusw@kernel.org>
Cc: "Mario Limonciello (AMD)" <superm1@kernel.org>,
Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
sashiko-bot@kernel.org
Subject: Re: [PATCH v2] pinctrl: amd: Clear interrupt enable bit on spurious GPIO IRQ
Date: Thu, 5 Nov 2026 11:46:36 -0600 [thread overview]
Message-ID: <39c2d670-4876-41be-ac90-af3db8faca8b@amd.com> (raw)
In-Reply-To: <CANA1Dbk=Xw==LBpLSsYAxBDQMzxpcvkWajwzuZUZRC5-w4oT9A@mail.gmail.com>
>>> When do_amd_gpio_irq_handler() detects a spurious interrupt on a pin
>>> that is not configured as an IRQ line (!gpiochip_line_is_irq()), it
>>> currently only clears BIT(INTERRUPT_MASK_OFF) while leaving
>>> BIT(INTERRUPT_ENABLE_OFF) set. Unlike amd_gpio_irq_disable(), leaving
>>> INTERRUPT_ENABLE_OFF enabled allows the pin interrupt status bit to
>>> keep asserting in WAKE_INT_STATUS_REG0/1.
>>>
>>> Clear both INTERRUPT_MASK_OFF and INTERRUPT_ENABLE_OFF when disabling
>>> a spurious GPIO IRQ on both the main and RGPIO banks.
>>>
>>> Signed-off-by: Munique Feitoza <muniquefeitoz4@gmail.com>
I'd like to understand more about this situation that lead you to this
patch before we decide which way to go on the patch.
Was this just analyzing the code and looking for a code flow problem?
Or do you have a real problem on a real system and came up with this to
fix it?
next prev parent reply other threads:[~2026-11-05 17:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 19:50 [PATCH] pinctrl: amd: Clear interrupt enable on spurious IRQ and skip unhandled EOI Munique Feitoza
2026-10-30 20:08 ` [PATCH v2] pinctrl: amd: Clear interrupt enable bit on spurious GPIO IRQ Munique Feitoza
2026-11-05 8:19 ` Linus Walleij
2026-11-05 14:49 ` Munique Feitoza
2026-11-05 17:46 ` Mario Limonciello [this message]
2026-11-05 8:18 ` [PATCH] pinctrl: amd: Clear interrupt enable on spurious IRQ and skip unhandled EOI Linus Walleij
2026-11-06 0:27 ` Munique Feitoza
2026-11-06 2:49 ` Mario Limonciello
2026-11-06 17:48 ` Munique Feitoza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39c2d670-4876-41be-ac90-af3db8faca8b@amd.com \
--to=mario.limonciello@amd.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muniquefeitoz4@gmail.com \
--cc=sashiko-bot@kernel.org \
--cc=superm1@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®